LearnNewsExamplesServices
Frontmatter
titleInlined healthHelpers.mjs into HealthService.mjs
authorMannXo
stateMerged
createdAtNov 11, 2025, 9:01 AM
updatedAtNov 11, 2025, 9:39 AM
closedAtNov 11, 2025, 9:35 AM
mergedAtNov 11, 2025, 9:35 AM
branchesdev ← Refactor/Inline-healthHelpers.mjs-into-HealthService.mjs
urlhttps://github.com/neomjs/neo/pull/7738
Merged
MannXo
MannXo commented on Nov 11, 2025, 9:01 AM

Summary

This PR refactors the GitHub workflow MCP server by inlining the healthHelpers.mjs module into HealthService.mjs as private methods, simplifying the architecture without sacrificing functionality.

Closes #7720

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills this requirement:

  • It's submitted to the dev branch, not the main branch

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

tobiu
tobiu commented on Nov 11, 2025, 9:35 AM

hi @MannXo! PR looks good. we need another follow-up ticket regarding parseVersionOutput (). the file is already importing semver, so we should use it. manually comparing semantic versions would be a quite complex topic. think of something like: v11.0.0-alpha.2 => the lib can handle it. off-topic: i will dive into the SEO epic next.

tobiu
tobiu commented on Nov 11, 2025, 9:39 AM

created the ticket here: https://github.com/neomjs/neo/issues/7739