LearnNewsExamplesServices
Frontmatter
id1010
titlelayout.Card, tab.Container: change the default of removeInactiveCards to true
stateClosed
labels
enhancement
assigneestobiu
createdAtAug 1, 2020, 5:09 AM
updatedAtAug 1, 2020, 8:27 PM
githubUrlhttps://github.com/neomjs/neo/issues/1010
authortobiu
commentsCount3
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtAug 1, 2020, 8:27 PM

layout.Card, tab.Container: change the default of removeInactiveCards to true

Closed v8.1.0 enhancement
tobiu
tobiu commented on Aug 1, 2020, 5:09 AM

this will affect a lot of demo apps (covid, docs, website,...) & examples, so it requires testing.

in case it works the way i think it should, it will increase the rendering performance by quite a bit.

tobiu added the enhancement label on Aug 1, 2020, 5:09 AM
tobiu assigned to @tobiu on Aug 1, 2020, 5:09 AM
tobiu
tobiu Aug 1, 2020, 5:25 AM

it does break the mapboxGL map & AmCharts. i guess we need to trigger the afterSetMount logic for this use case.

tobiu
tobiu Aug 1, 2020, 5:27 AM

docs app: dynamically added tabs do not get activated, highlightJS source views break. more work.

tobiu referenced in commit e3ed11f - "layout.Card, tab.Container: change the default of removeInactiveCards to true #1010" on Aug 1, 2020, 4:28 PM
tobiu
tobiu Aug 1, 2020, 4:28 PM

the mapboxGL & AmCharts part is fixed.

tobiu closed this issue on Aug 1, 2020, 8:27 PM