LearnNewsExamplesServices
Frontmatter
id10168
titleExpand mailbox test coverage and role-based addressing
stateClosed
labels
enhancementaitesting
assigneestobiu
createdAtApr 21, 2026, 11:24 PM
updatedAtApr 22, 2026, 1:25 AM
githubUrlhttps://github.com/neomjs/neo/issues/10168
authortobiu
commentsCount0
parentIssue10139
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 22, 2026, 1:25 AM

Expand mailbox test coverage and role-based addressing

Closed v13.0.0/archive-v13-0-0-chunk-5 enhancementaitesting
tobiu
tobiu commented on Apr 21, 2026, 11:24 PM

Context: Follow up to the Phase 3 Mailbox A2A integration (#10146, #10147). The core primitives were shipped in PR #10167, but test coverage for the expanded API surface and the role-based addressing mode were deferred to unblock Phase 4.

The Problem: Missing test coverage for pagination, outbox mode, advanced filtering, and edge creation leaves the new API surface vulnerable to regressions. Missing role-based addressing leaves the AC of #10147 incomplete.

The Architectural Reality: MailboxService.mjs handles the logic. Needs tests covering listMessages filters and addMessage full schema. Role-based addressing needs routing logic in MailboxService supporting role:<name> and human:<login>.

The Fix:

  • Add comprehensive tests to MailboxService.spec.mjs for all new features.
  • Implement role-based addressing parsing and permission evaluation.

Acceptance Criteria:

  • Outbox mode is tested.
  • Pagination (limit/offset) boundary behavior is tested.
  • Thread and sender filtering (threadId, from) are tested.
  • 6 new edge types are verified to be created and queryable.
  • Reachable Counterparty exception is tested.
  • listPermissions access-denied path is tested.
  • role:next-session, role:librarian, human:<login> addressing modes are implemented and tested.

Out of Scope: TAGGED_CONCEPT Gemma4 auto-emit (handled in separate ticket).

Origin Session ID: ada4aecb-60fc-4b25-a76b-cb92600835a2

tobiu added the enhancement label on Apr 21, 2026, 11:24 PM
tobiu added the ai label on Apr 21, 2026, 11:24 PM
tobiu added the testing label on Apr 21, 2026, 11:24 PM
tobiu added parent issue #10139 on Apr 21, 2026, 11:24 PM
tobiu assigned to @tobiu on Apr 21, 2026, 11:24 PM
tobiu cross-referenced by PR #10167 on Apr 21, 2026, 11:25 PM
tobiu cross-referenced by PR #10170 on Apr 22, 2026, 12:16 AM
tobiu referenced in commit 00f6578 - "test(mailbox): Add missing tests and document role symmetry (#10168)" on Apr 22, 2026, 12:40 AM
tobiu closed this issue on Apr 22, 2026, 1:25 AM
tobiu referenced in commit dd8e2f3 - "test+feat(mailbox): role-based addressing + expanded coverage + serial fixture isolation (#10168) (#10170) on Apr 22, 2026, 1:26 AM
tobiu cross-referenced by #9999 on Apr 22, 2026, 11:09 AM