Context
During the review of PR #10427, it was identified that while the author-side mandate for exact PR closing syntax (e.g., Resolves #N on a separate line) is codified in pull-request-workflow.md, the corresponding reviewer-side check is missing.
The Problem
pr-review-guide.md §5.2 Ticket Resolution Audit currently audits validity (epic vs leaf issue closures) but lacks an explicit audit for syntax correctness (newline-isolated vs prose-embedded or comma-separated). This creates an asymmetry where authors are instructed on strict syntax, but reviewers are not prompted to enforce it.
The Architectural Reality
.agent/skills/pr-review/references/pr-review-guide.md §5.2 Ticket Resolution Audit is the canonical reviewer-side checklist for verifying PR closures.
The Fix
Add an explicit audit step in pr-review-guide.md §5.2 requiring reviewers to verify that PR bodies adhere to the "Syntax-Exact Keyword Mandate." Reviewers must ensure that closing keywords (like Resolves #N) are isolated on their own lines and that multiple tickets are closed on separate lines, rejecting prose-embedded or comma-separated closures.
Acceptance Criteria
- Update
.agent/skills/pr-review/references/pr-review-guide.md §5.2 to include the Syntax-Exact Keyword Mandate audit.
- Explicitly instruct reviewers to request changes if a PR uses embedded or comma-separated closing keywords.
Out of Scope
- Implementing GitHub Actions or automated API checks for this syntax. Enforcement remains procedural via the agent skill docs.
Related
- Sibling to the author-side update from PR #10427.
Origin Session ID: 49e9b05a-0581-4fb7-861f-7e4970ea4c2b
Context During the review of PR #10427, it was identified that while the author-side mandate for exact PR closing syntax (e.g.,
Resolves #Non a separate line) is codified inpull-request-workflow.md, the corresponding reviewer-side check is missing.The Problem
pr-review-guide.md §5.2 Ticket Resolution Auditcurrently audits validity (epic vs leaf issue closures) but lacks an explicit audit for syntax correctness (newline-isolated vs prose-embedded or comma-separated). This creates an asymmetry where authors are instructed on strict syntax, but reviewers are not prompted to enforce it.The Architectural Reality
.agent/skills/pr-review/references/pr-review-guide.md §5.2 Ticket Resolution Auditis the canonical reviewer-side checklist for verifying PR closures.The Fix Add an explicit audit step in
pr-review-guide.md §5.2requiring reviewers to verify that PR bodies adhere to the "Syntax-Exact Keyword Mandate." Reviewers must ensure that closing keywords (likeResolves #N) are isolated on their own lines and that multiple tickets are closed on separate lines, rejecting prose-embedded or comma-separated closures.Acceptance Criteria
.agent/skills/pr-review/references/pr-review-guide.md §5.2to include the Syntax-Exact Keyword Mandate audit.Out of Scope
Related
Origin Session ID: 49e9b05a-0581-4fb7-861f-7e4970ea4c2b