Frontmatter
| id | 10529 |
| title | Disambiguate session sunset triggers from PR review halting |
| state | Closed |
| labels | enhancementaiarchitecture |
| assignees | [] |
| createdAt | Apr 30, 2026, 3:58 PM |
| updatedAt | Apr 30, 2026, 4:21 PM |
| githubUrl | https://github.com/neomjs/neo/issues/10529 |
| author | neo-gemini-3-1-pro |
| commentsCount | 0 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Apr 30, 2026, 4:21 PM |
Disambiguate session sunset triggers from PR review halting
Closedenhancementaiarchitecture
- Context — The
session-sunset-workflow.md forbids sunsetting when an agent simply halts for a turn. However, the pull-request-workflow.md explicitly commands an agent to "halt and await cross-model review" after opening a PR. Agents have erroneously conflated this PR halting state with a Session Boundary, causing false-positive Sunset Protocol executions.
- The Problem — Opening a PR starts an async review lifecycle; it does not terminate a session. Executing the Sunset Protocol at this point causes unnecessary overhead, pollutes the context with Sandman memories prematurely, and disrupts swarm continuity if the PR requires immediate polish.
- The Architectural Reality — The
session-sunset-workflow.md lacks an explicit negative trigger (Anti-Trigger) for the Review Lifecycle. The agent's autonomous loops cannot distinguish between "halting to await human input" and "halting for PR peer review" without this explicit rule.
- The Fix — Add an explicit "Review Lifecycle Exception (Anti-Trigger)" to
.agents/skills/session-sunset/references/session-sunset-workflow.md. Clarify that awaiting cross-model review is NOT a Session Boundary.
- Acceptance Criteria
- Update
session-sunset-workflow.md to explicitly list PR Review halting as a non-trigger.
- Remove any ambiguity between yielding a turn and terminating a session in the context of PRs.
- Out of Scope — Modifying the
pull-request skill or ticket-intake skill.
- Related — #9948
tobiu referenced in commit
f50db54 - "feat(sunset): disambiguate session sunset triggers from PR review halting (#10529) (#10530)
on Apr 30, 2026, 4:21 PM
tobiu closed this issue
on Apr 30, 2026, 4:21 PM
session-sunset-workflow.mdforbids sunsetting when an agent simply halts for a turn. However, thepull-request-workflow.mdexplicitly commands an agent to "halt and await cross-model review" after opening a PR. Agents have erroneously conflated this PR halting state with a Session Boundary, causing false-positive Sunset Protocol executions.session-sunset-workflow.mdlacks an explicit negative trigger (Anti-Trigger) for the Review Lifecycle. The agent's autonomous loops cannot distinguish between "halting to await human input" and "halting for PR peer review" without this explicit rule..agents/skills/session-sunset/references/session-sunset-workflow.md. Clarify that awaiting cross-model review is NOT a Session Boundary.session-sunset-workflow.mdto explicitly list PR Review halting as a non-trigger.pull-requestskill orticket-intakeskill.