LearnNewsExamplesServices
Frontmatter
id1053
titleCalendar Week View: moving an event into a column on the right breaks the vdom engine
stateClosed
labels
bug
assigneestobiu
createdAtAug 13, 2020, 6:32 PM
updatedAtAug 13, 2020, 6:33 PM
githubUrlhttps://github.com/neomjs/neo/issues/1053
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtAug 13, 2020, 6:33 PM

Calendar Week View: moving an event into a column on the right breaks the vdom engine

Closed v8.1.0 bug
tobiu
tobiu commented on Aug 13, 2020, 6:32 PM

A bit of an edge case, but it is obviously supposed to work.

Screenshot 2020-08-13 at 18 21 13

We move an event from one column into a column to the right. Columns have their own child arrays. We also add a new CSS class.

idea:

Screenshot 2020-08-13 at 18 20 14

We check the old tree, if the node exists there. If so, we move the real dom of the node to the new spot.

Now this is the part, which is a bit hack-ish (feels smart though). While we can not touch the new vnode (would just break the state completely), we actually put the node into the new spot, just inside the old tree.

This way, the delta comparisons of the old and new node will happen out of the box.

It is an expensive search task, but reduces the work once the engine arrives at the modified child array: We do not get additional index changes, since the arrays are in sync.

The change did not break any other test cases, but needs some testing.

tobiu added the bug label on Aug 13, 2020, 6:32 PM
tobiu assigned to @tobiu on Aug 13, 2020, 6:32 PM
tobiu referenced in commit c92908f - "Calendar Week View: moving an event into a column on the right breaks the vdom engine #1053" on Aug 13, 2020, 6:33 PM
tobiu closed this issue on Aug 13, 2020, 6:33 PM