LearnNewsExamplesServices
Frontmatter
id1070
titleResponsive Components: switch all theme CSS rules from px to em
stateClosed
labels
enhancementhelp wantedgood first issuestale
assignees[]
createdAtAug 14, 2020, 10:55 PM
updatedAtSep 27, 2024, 4:34 AM
githubUrlhttps://github.com/neomjs/neo/issues/1070
authortobiu
commentsCount4
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 27, 2024, 4:34 AM

Responsive Components: switch all theme CSS rules from px to em

Closed v8.1.0 enhancementhelp wantedgood first issuestale
tobiu
tobiu commented on Aug 14, 2020, 10:55 PM

strategy: we need to start with font-sizes, since the base unit (font-size) should be 16px for all components.

afterwards: 1em == 16px => convert the values.

exception: borders need to stay px based.

a pretty big, but trivial ticket. we should split it up as needed.

i will probably refactor component.DateSelector very soon.

tobiu added the enhancement label on Aug 14, 2020, 10:55 PM
tobiu added the help wanted label on Aug 14, 2020, 10:55 PM
tobiu added the good first issue label on Aug 14, 2020, 10:55 PM
TatisLois
TatisLois Oct 1, 2020, 7:26 PM

Hey @tobiu seems like a straightforward but tedious task, probably a great candidate to get familiar with the codebase.

Is this something I can take up? :)

tobiu
tobiu Oct 1, 2020, 8:27 PM

Welcome @TatisLois,

to get familiar with the code base, I recommend to take a look at the 2 covid app tutorials first:

https://neomjs.github.io/pages/node_modules/neo.mjs/dist/production/apps/website/index.html#mainview=blog

=> https://medium.com/swlh/how-to-create-a-webworkers-driven-multithreading-app-part-1-fa0cc78a4237?source=friends_link&sk=a10ca85002f5f9c3ee8c69f53c79d95f

Of course, help on this ticket is greatly appreciated. I would create new related tickets to keep it reasonable, e.g. button.Base: em based styling.

I am working on drag&drop support for lists & tree lists next, since I need this one for a client project.

Best regards, Tobias

@github-actions - 2024-09-13T02:31:20Z

This issue is stale because it has been open for 90 days with no activity.

  • 2024-09-13T02:31:21Z @github-actions added the stale label

@github-actions - 2024-09-27T02:34:32Z

This issue was closed because it has been inactive for 14 days since being marked as stale.

  • 2024-09-27T02:34:33Z @github-actions closed this issue