LearnNewsExamplesServices
Frontmatter
id10887
titleInstitutionalize Test Location Audit in PR Review and Pre-Flight Skills
stateClosed
labels[]
assigneesneo-gemini-3-1-pro
createdAtMay 7, 2026, 12:08 PM
updatedAtMay 7, 2026, 1:17 PM
githubUrlhttps://github.com/neomjs/neo/issues/10887
authorneo-gemini-3-1-pro
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMay 7, 2026, 1:17 PM

Institutionalize Test Location Audit in PR Review and Pre-Flight Skills

Closed[]
neo-gemini-3-1-pro
neo-gemini-3-1-pro commented on May 7, 2026, 12:08 PM

Problem: During the review of PR #10886, incorrect or sub-optimal test file placements were missed by the reviewing agents. While the unit-test skill (.agents/skills/unit-test/references/unit-test.md) strictly defines canonical test directories (e.g., forcing MCP tests into test/playwright/unit/ai/mcp/server/), the pr-review and pull-request skills lacked structural mandates to check these locations during the review and pre-flight phases.

Impact:

  • Agents may approve PRs where test files are placed in legacy or non-canonical directories.
  • Technical debt accumulates as test file locations drift from the established standards.
  • Re-reviews are required (e.g., in PR #10886) to correct placements that should have been caught during the first review cycle.

Proposed Solution:

  • Update PR Review Guide: Modify §7.5 Test-Execution Audit to Test-Execution & Location Audit, explicitly requiring reviewers to verify canonical file placement against unit-test.md.
  • Update Review Templates: Add a checkbox to both the full and follow-up PR review templates to explicitly mandate the location check.
  • Update PR Pre-Flight Gate: Modify the pull-request-workflow.md "Stepping Back" protocol to require PR authors to verify their test placements before opening the PR.

Acceptance Criteria:

  • PR Review Guide updated to mandate test location verification.
  • Full and Follow-Up PR Review templates updated with a location check checkbox.
  • Pull Request workflow updated to include incorrect test placement as a minor gap in the pre-flight check.

Labels: ai, enhancement, documentation

tobiu referenced in commit 5a3a371 - "feat(skills): institutionalize test location audit in PR reviews (#10887) (#10888) on May 7, 2026, 1:13 PM
tobiu assigned to @neo-gemini-3-1-pro on May 7, 2026, 1:17 PM
tobiu
tobiu May 7, 2026, 1:17 PM
tobiu closed this issue on May 7, 2026, 1:17 PM