LearnNewsExamplesServices
Frontmatter
id11835
titleSub 3: Removal of DEFAULT_* constants + parser surfaces made obsolete by Orchestrator refactor
stateClosed
labels
enhancementairefactoring
assigneesneo-opus-ada
createdAtMay 23, 2026, 1:22 PM
updatedAtJun 7, 2026, 7:14 PM
githubUrlhttps://github.com/neomjs/neo/issues/11835
authorneo-opus-ada
commentsCount0
parentIssue11831
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMay 23, 2026, 3:28 PM

Sub 3: Removal of DEFAULT_* constants + parser surfaces made obsolete by Orchestrator refactor

Closed v13.0.0/archive-v13-0-0-chunk-13 enhancementairefactoring
neo-opus-ada
neo-opus-ada commented on May 23, 2026, 1:22 PM

Parent Epic

#11831Sub 3 of 6 (parallel after Sub 1; subsumes #11827).

Scope

Delete the now-obsolete parser-surface debris after Sub 1 + Sub 6 land. Closes #11827 audit-ticket as superseded by this Epic.

Acceptance Criteria

  1. ai/daemons/services/CadenceEngine.parseInterval retired (consumers rewire to Env.parseNumber() + caller wraps in Math.max(0, n) where non-negative semantics required).
  2. ai/daemons/services/PrimaryRepoSyncService.parseEnabledFlag retired (consumers rewire to Env.parseBool() which preserves the legacy '0'/'no'/'off' token semantics per Sub 6 AC3).
  3. ai/mcp/server/shared/helpers/EnvConfig.mjs retired OR provides compatibility-forwarding to Neo.util.Env (decision deferred to Sub 6a MCP-cluster migration).
  4. SwarmHeartbeatService.mjs:37 LOCAL DEFAULT_POLL_INTERVAL_MS = 5 * 60 * 1000 deleted (drifted 100× from TaskDefinitions.mjs value of 3000 — eliminate the source of drift).
  5. KbAlertRuleEngine.mjs:56 DEFAULT_COOLDOWN_MS deleted (duplicate of aiConfig.knowledgeBase.alertingCooldownMs).
  6. #11827 closed as superseded by this Epic.
  7. Post-deletion grep returns zero matches: grep -rnE '^export const DEFAULT_[A-Z_]+_MS|^export const DEFAULT_[A-Z_]+(INTERVAL|TIMEOUT|THRESHOLD)' ai --include='*.mjs' (or only ai/config.template.mjs if that file uses the constant naming pattern internally).

Files (touched)

  • ai/daemons/services/CadenceEngine.mjs (delete parseInterval)
  • ai/daemons/services/PrimaryRepoSyncService.mjs (delete parseEnabledFlag; rewire callers to Env.parseBool)
  • ai/daemons/services/SwarmHeartbeatService.mjs:37 (delete LOCAL DEFAULT_POLL_INTERVAL_MS drift)
  • ai/daemons/services/KbAlertRuleEngine.mjs:56 (delete DEFAULT_COOLDOWN_MS)
  • ai/daemons/TaskDefinitions.mjs (delete 8 DEFAULT_X_INTERVAL_MS exports — actually delegated to Sub 1)
  • ai/mcp/server/shared/helpers/EnvConfig.mjs (defer to Sub 6a/6b consumer rewire)

Authored by: [Claude Opus 4.7] (Claude Code)

tobiu referenced in commit 27f7a65 - "refactor(agentos): Orchestrator masterclass-reference (4-way Service-DI + Neo.util.Env + configure() removal) (#11833) (#11842) on May 23, 2026, 3:10 PM
tobiu referenced in commit 7e7adb2 - "refactor(agentos): delete obsolete CadenceEngine.parseInterval + PrimaryRepoSyncService.parseEnabledFlag (#11835) (#11843) on May 23, 2026, 3:28 PM
tobiu closed this issue on May 23, 2026, 3:28 PM