LearnNewsExamplesServices
Frontmatter
id11836
titleSub 4: Sibling daemon propagation of masterclass-reference pattern (5-6 daemon files)
stateClosed
labels
enhancementairefactoringarchitecture
assigneesneo-gpt
createdAtMay 23, 2026, 1:22 PM
updatedAtJun 7, 2026, 7:14 PM
githubUrlhttps://github.com/neomjs/neo/issues/11836
authorneo-opus-ada
commentsCount2
parentIssue11831
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJun 6, 2026, 11:51 PM

Sub 4: Sibling daemon propagation of masterclass-reference pattern (5-6 daemon files)

Closed v13.0.0/archive-v13-0-0-chunk-13 enhancementairefactoringarchitecture
neo-opus-ada
neo-opus-ada commented on May 23, 2026, 1:22 PM

Parent Epic

#11831Sub 4 of 6 (parallel after Sub 1 sets the masterclass-reference).

Scope

Propagate the 4-way Service-DI classification + 2-value chain + Neo.util.Env consumption pattern to sibling daemon files. May decompose into per-daemon sub-tickets if review burden warrants.

Acceptance Criteria

For each daemon file:

  1. Drop cargo-cult _-suffix configs (no hooks → no _).
  2. Lazy getters for operator policy values: Env.parseNumber(process.env.X, 'X') ?? AiConfig.namespace.X.
  3. Class-system-managed collaborators with ClassSystemUtil.beforeSetInstance(value, DefaultClass, defaults) where applicable.
  4. Parent-configured child collaborators with beforeSet* + parent afterSet* propagation hooks where applicable.
  5. Per-file test refactor parallels Sub 2's test-fixture pattern.

Target daemon files

  • ai/daemons/services/SwarmHeartbeatService.mjs
  • ai/daemons/services/KbAlertingService.mjs (recently normalized in PR #11813; verify shape matches)
  • ai/daemons/services/KbReconciliationService.mjs
  • ai/daemons/services/KbGarbageCollectionService.mjs
  • ai/daemons/services/GapInferenceEngine.mjs
  • (Per-file audit may surface additional candidates)

Decomposition decision

If review burden for all 5-6 daemons in one PR exceeds the §7.5 unit-test-budget envelope: decompose into Sub 4a/4b/etc per-daemon. Default: try one consolidated PR; split if cycle-burden surfaces.

Authored by: [Claude Opus 4.7] (Claude Code)

tobiu referenced in commit 7e7adb2 - "refactor(agentos): delete obsolete CadenceEngine.parseInterval + PrimaryRepoSyncService.parseEnabledFlag (#11835) (#11843) on May 23, 2026, 3:28 PM
tobiu referenced in commit aef235c - "refactor(agentos): drop hookless daemon config suffixes (#11836) (#12657)" on Jun 6, 2026, 11:51 PM
tobiu closed this issue on Jun 6, 2026, 11:51 PM