Parent epic: #11912
Context
#11912 is being reshaped into an epic with grouped cleanup subissues. This subissue owns GitHub Workflow services and shared MCP runtime surfaces.
Current grouped baseline on origin/dev:
ai/services/github-workflow/**/*.mjs plus ai/mcp/server/github-workflow/**/*.mjs: 93 diagnostic matches.
ai/mcp/server/shared/**/*.mjs: 37 diagnostic matches.
- Top files include
PullRequestService.mjs, IssueSyncer.mjs, IssueService.mjs, toolService.mjs, RequestContextService.mjs, and shared auth/transport helpers.
The Problem
GitHub Workflow and shared MCP comments often cite specific PR cycles, ACs, and historical incidents. These comments should instead describe durable API, sync, auth, transport, and graph-ingestion contracts.
The Architectural Reality
This group mediates GitHub issue/PR/discussion sync, review and relationship tooling, shared request context, auth, and transport behavior. Comments in this layer are read by agents during live workflow execution, so stale archaeology can distort current operational decisions.
The Fix
Clean GitHub Workflow and shared MCP source comments in grouped batches:
- Rewrite ticket/PR/AC/cycle references into stable API and service-boundary contracts.
- Preserve references to public GitHub semantics or schema names when those are the stable authority.
- Document false positives and runtime strings that are intentionally left unchanged.
- Keep generated OpenAPI/YAML or resource mirrors out of scope unless a
.mjs source comment points to them incorrectly.
Contract Ledger Matrix
| Target Surface |
Source of Authority |
Proposed Behavior |
Fallback |
Docs |
Evidence |
| GitHub Workflow service comments/JSDoc |
#11912 source-comment cleanup epic |
Comments explain sync/review/relationship contracts without PR-cycle archaeology |
File separate runtime/schema ticket if cleanup finds drift |
PR bodies |
Before/after focused diagnostics |
| Shared MCP runtime comments/JSDoc |
#11912 source-comment cleanup epic |
Comments explain auth/request/transport boundaries in stable terms |
Preserve public API names and exact header names |
PR bodies |
Before/after focused diagnostics |
Decision Record Impact
Aligned with ADR 0005 and ADR 0008. No ADR amendment expected.
Acceptance Criteria
Out of Scope
- Memory Core, Knowledge Base/Graph, daemon/script, and residual config groups.
- Runtime behavior changes.
- Generated issue/PR/discussion mirrors.
Related
Origin Session ID: 019e5bac-15f3-7830-a59c-72772c757f9a
Handoff Retrieval Hint: query_raw_memories("11912 github-workflow shared MCP RequestContext source-comment archaeology")
Parent epic: #11912
Context
#11912 is being reshaped into an epic with grouped cleanup subissues. This subissue owns GitHub Workflow services and shared MCP runtime surfaces.
Current grouped baseline on
origin/dev:ai/services/github-workflow/**/*.mjsplusai/mcp/server/github-workflow/**/*.mjs: 93 diagnostic matches.ai/mcp/server/shared/**/*.mjs: 37 diagnostic matches.PullRequestService.mjs,IssueSyncer.mjs,IssueService.mjs,toolService.mjs,RequestContextService.mjs, and shared auth/transport helpers.The Problem
GitHub Workflow and shared MCP comments often cite specific PR cycles, ACs, and historical incidents. These comments should instead describe durable API, sync, auth, transport, and graph-ingestion contracts.
The Architectural Reality
This group mediates GitHub issue/PR/discussion sync, review and relationship tooling, shared request context, auth, and transport behavior. Comments in this layer are read by agents during live workflow execution, so stale archaeology can distort current operational decisions.
The Fix
Clean GitHub Workflow and shared MCP source comments in grouped batches:
.mjssource comment points to them incorrectly.Contract Ledger Matrix
Decision Record Impact
Aligned with ADR 0005 and ADR 0008. No ADR amendment expected.
Acceptance Criteria
.mjscomments/JSDoc to durable intent phrasing..mjscomments/JSDoc to durable intent phrasing.git diff --check.Out of Scope
Related
Origin Session ID: 019e5bac-15f3-7830-a59c-72772c757f9a
Handoff Retrieval Hint:
query_raw_memories("11912 github-workflow shared MCP RequestContext source-comment archaeology")