Stage 3: orchestrator codemod — delete 16 delegation getters

Context

Stage 3 of Epic #12101 (Greenfield aiConfig). Sub-class C from the Discussion #12100 consumer ledger: pure delegation getters of the form get X() { return AiConfig.X.Y }, introduced in PR #12098. Discussion #12100 universal-bans them — "getter is pure indirection; consumer should read aiConfig.X.Y at point of use" — as part of retiring ~900–1200 LOC of getter/validator/duplication boilerplate.

A fresh inventory (2026-05-30) finds 19 such getters in ai/daemons/orchestrator/Orchestrator.mjs — up from the 16 the title cites; the tenantRepoSync.* + lms/mlx getters landed after #12100's count. The original title figure is therefore stale; the ledger below is authoritative.

Migration shape: delete the getter, inline its AiConfig.<path> read at each call site. Behaviour-preserving.

Contract Ledger

• Before (uniform): this.<getter> read inside Orchestrator.mjs.
• After: the inline AiConfig.<path> expression at point of use (see table).
• Source of authority: AiConfig (the Tier-1 realm root Neo.ai.Config).
• Consumers: internal only — ~25 this.<getter> reads in Orchestrator.mjs (task-definition options ~478–486, scheduling configs, chroma reaper 637/655/695, poll loop 918, start-log 556, swarm-heartbeat wiring 545–546). No external consumers — the ai/daemons/kb-*/Kb*Service.mjs this.pollIntervalMs fields are independent (set from their own config), and the TaskDefinitions.mjs / scheduling/*.mjs matches are @param docs for the passed options, not the getters. Verified by grep 2026-05-30.
• Tests: test/playwright/unit/ai/daemons/orchestrator/Orchestrator.invariants.spec.mjs + Orchestrator.spec.mjs — confirm none assert via a deleted getter; update any that do.

Acceptance Criteria

• AC-Stage3-1: Delete all 19 pure-delegation getters (body matches return AiConfig…) from Orchestrator.mjs.
• AC-Stage3-2: Replace every internal this.<getter> read with the inline AiConfig.<path> read from the ledger. Behaviour unchanged (same values, read at point of use).
• AC-Stage3-3: No external consumer touched (verified none); the Kb*Service / TaskDefinitions matches are unrelated and stay as-is.
• AC-Stage3-4: Orchestrator unit + invariant specs green; add/adjust coverage if any asserted through a now-deleted getter.

Out of Scope

• Logic-bearing getters — mlxEnabled / lmsEnabled (!! coercion), the *Enabled getters (delegate to resolveDeploymentEnabled / resolveCloudOnlyEnabled), swarmHeartbeatIdentity (Env.parseString), and the multi-line swarmHeartbeatExplicitTargets / lmsModels blocks. These are NOT pure delegation; any seam decision is separate.
• Sub-class E (hidden-default-fallback) — #12100 folds it into the Stage-3+ sweep, but it is a distinct ban; track separately if hits surface here.
• Stage 4 services + MCP-server codemod (#12106).
• The thin-child overlay (the reframed #12102).

Related

• Parent Epic: #12101 (Stage 3). Source: Discussion #12100 (sub-class C; §"Stage 3 codemod-sweep prep" — "16 sites … mechanical delete-getter + replace-with-inline-read"). Sibling: #12106 (Stage 4).
• Anti-pattern origin: PR #12098.