LearnNewsExamplesServices
Frontmatter
id1215
titleNeo.config.environment (dev, dist/dev, dist/prod)
stateClosed
labels
enhancement
assigneestobiu
createdAtSep 21, 2020, 1:42 PM
updatedAtSep 21, 2020, 2:49 PM
githubUrlhttps://github.com/neomjs/neo/issues/1215
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 21, 2020, 2:49 PM

Neo.config.environment (dev, dist/dev, dist/prod)

Closed v8.1.0 enhancement
tobiu
tobiu commented on Sep 21, 2020, 1:42 PM

We are still using Neo.config.isExperimental.

At this point, the name is most likely no longer clear to anyone :)

Before Chrome v81, we needed an experimental web platform features flag, to enable JS modules inside the worker scope.

This one is no longer needed and the config just means mode: dev.

Will add the new config now and remove the old one once ready.

tobiu added the enhancement label on Sep 21, 2020, 1:42 PM
tobiu assigned to @tobiu on Sep 21, 2020, 1:42 PM
tobiu referenced in commit b53754d - "#1215 added mode: 'dev' into the index files of the apps folder" on Sep 21, 2020, 1:48 PM
tobiu changed title from Neo.config.mode (dev, dist/dev, dist/prod) to Neo.config.environment (dev, dist/dev, dist/prod) on Sep 21, 2020, 1:54 PM
tobiu
tobiu Sep 21, 2020, 1:55 PM

since we already have Neo.config.environment, i will stick to this one and add the dev mode here.

new values:

  • development
  • dist/development
  • dist/production
tobiu referenced in commit 65e8be7 - "#1215 adjusted the DefaultConfig environment docs comment & default value" on Sep 21, 2020, 1:57 PM
tobiu referenced in commit 8cc4650 - "#1215 main.addon.Stylesheet: adjusted to the new Neo.config.environment values" on Sep 21, 2020, 1:58 PM
tobiu referenced in commit 95cb81b - "#1215 apps index files: removed the mode & isExperimental configs" on Sep 21, 2020, 2:02 PM
tobiu referenced in commit a1bed9b - "#1215 DefaultConfig: removed isExperimental" on Sep 21, 2020, 2:02 PM
tobiu referenced in commit b1fd895 - "#1215 examples index files: removed the isExperimental configs" on Sep 21, 2020, 2:10 PM
tobiu referenced in commit 864e711 - "#1215 adjusted the env config inside the buildScripts" on Sep 21, 2020, 2:13 PM
tobiu referenced in commit 7ab8fdc - "#1215 src folder: replaced all checks for Neo.config.isExperimental with Neo.config.environment" on Sep 21, 2020, 2:18 PM
tobiu referenced in commit d895caf - "#1215 apps folder: replaced all checks for Neo.config.isExperimental with Neo.config.environment" on Sep 21, 2020, 2:23 PM
tobiu referenced in commit f8cece7 - "#1215 webstorm auto-import fix" on Sep 21, 2020, 2:25 PM
tobiu referenced in commit 3c2df0b - "#1215 docs app: replaced all checks for Neo.config.isExperimental with Neo.config.environment" on Sep 21, 2020, 2:31 PM
tobiu referenced in commit 2ede876 - "#1215 removed Neo.config.isExperimental from the createApp program" on Sep 21, 2020, 2:33 PM
tobiu referenced in commit a02afa9 - "#1215 removed Neo.config.isExperimental from the siesta testing setups" on Sep 21, 2020, 2:35 PM
tobiu referenced in commit 615bb8e - "#1215 App worker path fix, stylesheet main thread addon => switch to the dist/development theme again for the development mode" on Sep 21, 2020, 2:48 PM
tobiu
tobiu Sep 21, 2020, 2:49 PM

done.

tobiu closed this issue on Sep 21, 2020, 2:49 PM