LearnNewsExamplesServices
Frontmatter
id12213
titlePortal Pull Request view — Portal.view.news.pulls (two-section parser)
stateClosed
labels
enhancementai
assigneesneo-opus-ada
createdAtMay 30, 2026, 7:26 PM
updatedAtJun 1, 2026, 10:52 AM
githubUrlhttps://github.com/neomjs/neo/issues/12213
authorneo-opus-ada
commentsCount0
parentIssue12204
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[x] 12210 Portal index generators for Pull Requests + Discussions (chunked output)
blocking[]
closedAtJun 1, 2026, 10:52 AM

Portal Pull Request view — Portal.view.news.pulls (two-section parser)

Closed Backlog/active-chunk-16 enhancementai
neo-opus-ada
neo-opus-ada commented on May 30, 2026, 7:26 PM

Context

Part of epic #12207. PR conversations carry the richest architectural context (review scores, diffs, Fat-Ticket metadata) but are invisible to humans + SEO.

The Fix

New pulls section (copy the release/tickets pattern). The Component implements the PR-specific parser:

  • two-section extract of ## Comments + ## Reviews;
  • entry-split only at the ### `@user` ... header boundary (NOT bare --- — bodies contain their own ### sub-headers and --- rules);
  • two header grammars (commented on <ts> / (STATE) reviewed on <ts>);
  • merge-sort by timestamp (the two sections are not globally ordered);
  • review STATE → color (APPROVED green, CHANGES_REQUESTED red, neutral fallback for unknown/COMMENTED/DISMISSED — do not throw);
  • dependabot zero-section degrade via super.modifyMarkdown (body-only PRs still render).

Plus a 3-state OPEN / MERGED / CLOSED badge (the issue 2-way version mislabels MERGED) + base ← head / url / mergedAt frontmatter renderers. Consumes pulls.json.

Acceptance Criteria

  • Pull Requests tab renders PR body + comments + reviews on the shared timeline + canvas.
  • Reviews entry-split correctly (no shredding on inner ###/---); MERGED state rendered distinctly.

Related

Epic #12207. Depends on: generators (sub 6), shared-contract extraction (foundation 4), per-type URLs (foundation 5). Grammar source-of-truth: sub 9.

tobiu referenced in commit c35256b - "feat(portal): Pull Requests news view — Portal.view.news.pulls (#12213) (#12287) on Jun 1, 2026, 10:52 AM
tobiu closed this issue on Jun 1, 2026, 10:52 AM