LearnNewsExamplesServices
Frontmatter
id1238
titlecomponent.Base: getTheme()
stateClosed
labels
enhancement
assigneestobiu
createdAtOct 12, 2020, 11:32 AM
updatedAtOct 12, 2020, 12:27 PM
githubUrlhttps://github.com/neomjs/neo/issues/1238
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 12, 2020, 12:27 PM

component.Base: getTheme()

Closed v8.1.0 enhancement
tobiu
tobiu commented on Oct 12, 2020, 11:32 AM

A Component should be aware of the closest theme which is applied.

Since we can apply a neo theme to any div node, we should check the Component class array for "neo-theme-" matches. If there is no entry, walk up the vdom tree and check each node if it has a theme css rule.

tobiu added the enhancement label on Oct 12, 2020, 11:32 AM
tobiu assigned to @tobiu on Oct 12, 2020, 11:32 AM
tobiu referenced in commit 8354879 - "component.Base: getTheme() #1238 (in progress)" on Oct 12, 2020, 11:48 AM
tobiu referenced in commit 4d4d29b - "component.Base: getTheme() #1238" on Oct 12, 2020, 12:27 PM
tobiu closed this issue on Oct 12, 2020, 12:27 PM
tobiu referenced in commit 9185a04 - "#1238 cleanup" on Oct 12, 2020, 12:29 PM