LearnNewsExamplesServices
Frontmatter
id1244
titlemain.addon.DragDrop: onDragMove() => always fire the event
stateClosed
labels
enhancement
assigneestobiu
createdAtOct 13, 2020, 11:46 AM
updatedAtOct 14, 2020, 2:18 PM
githubUrlhttps://github.com/neomjs/neo/issues/1244
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 14, 2020, 2:18 PM

main.addon.DragDrop: onDragMove() => always fire the event

Closed v8.1.0 enhancement
tobiu
tobiu commented on Oct 13, 2020, 11:46 AM

we should forward drag:move to the app worker, even in case we are using the main thread to handle the dragProxy movement.

this way we can add additional logic (e.g. for sort zones).

tobiu added the enhancement label on Oct 13, 2020, 11:46 AM
tobiu assigned to @tobiu on Oct 13, 2020, 11:46 AM
tobiu referenced in commit b61bf82 - "main.addon.DragDrop: onDragMove() => always fire the event #1244" on Oct 13, 2020, 11:48 AM
tobiu
tobiu Oct 13, 2020, 12:19 PM

thinking more about this one, it feels too expensive since drag:move fires very often.

i will add a new config like "alwaysFireDragMove" to make it optional in case moveInMainThread === true.

tobiu referenced in commit b3e2bc3 - "#1244 draggable.DragZone: alwaysFireDragMove config" on Oct 13, 2020, 12:26 PM
tobiu referenced in commit 6e711e6 - "#1244 main.addon.DragDrop: alwaysFireDragMove config" on Oct 13, 2020, 12:30 PM
tobiu referenced in commit 3ccd6fc - "#1244 main.addon.DragDrop: fire drag:move optionally" on Oct 13, 2020, 12:35 PM
tobiu closed this issue on Oct 14, 2020, 2:18 PM