LearnNewsExamplesServices
Frontmatter
id1298
titledraggable.tab.header.toolbar.SortZone: disable the tab strip animation after a drop happens
stateClosed
labels
enhancement
assigneestobiu
createdAtOct 24, 2020, 3:00 PM
updatedAtOct 24, 2020, 4:04 PM
githubUrlhttps://github.com/neomjs/neo/issues/1298
authortobiu
commentsCount3
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtOct 24, 2020, 4:04 PM

draggable.tab.header.toolbar.SortZone: disable the tab strip animation after a drop happens

Closed v8.1.0 enhancement
tobiu
tobiu commented on Oct 24, 2020, 3:00 PM

drag&drop based re-sorting can change the active index.

in this case, the active tab indicator should not move with an animation.

an edge case, but to make it perfect it should move instantly.

tobiu added the enhancement label on Oct 24, 2020, 3:00 PM
tobiu assigned to @tobiu on Oct 24, 2020, 3:00 PM
tobiu
tobiu Oct 24, 2020, 3:03 PM

the logic needs to be inside: draggable.tab.header.toolbar.SortZone.

will adjust the ticket title.

tobiu changed title from draggable.toolbar.SortZone: disable the tab strip animation after a drop happens to draggable.tab.header.toolbar.SortZone: disable the tab strip animation after a drop happens on Oct 24, 2020, 3:03 PM
tobiu
tobiu Oct 24, 2020, 3:45 PM

it turns out, that adding a style like animation: none !important to the toolbar or each button does not override the value inside the button indicator child node (only tested in Chrome).

we need to add a custom css rule to make it work.

tobiu referenced in commit dd9771c - "draggable.tab.header.toolbar.SortZone: disable the tab strip animation after a drop happens #1298" on Oct 24, 2020, 3:59 PM
tobiu
tobiu Oct 24, 2020, 4:00 PM

i will test adding the new cls onDragStart(), so that the dragProxyEl tab indicator does not flicker.

tobiu referenced in commit cb61028 - "#1298 adding the rule onDragStart() already to ensure the proxyEl indicator does not flicker" on Oct 24, 2020, 4:03 PM
tobiu closed this issue on Oct 24, 2020, 4:04 PM