LearnNewsExamplesServices
Frontmatter
id1383
titledraggable.DragZone: fire events on itself when drop related events arrive
stateClosed
labels
enhancement
assigneestobiu
createdAtNov 4, 2020, 12:18 PM
updatedAtNov 4, 2020, 1:23 PM
githubUrlhttps://github.com/neomjs/neo/issues/1383
authortobiu
commentsCount3
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtNov 4, 2020, 1:23 PM

draggable.DragZone: fire events on itself when drop related events arrive

Closed v8.1.0 enhancement
tobiu
tobiu commented on Nov 4, 2020, 12:18 PM

to make it easier to subscribe to them from the outside

tobiu added the enhancement label on Nov 4, 2020, 12:18 PM
tobiu assigned to @tobiu on Nov 4, 2020, 12:18 PM
tobiu
tobiu Nov 4, 2020, 12:18 PM

this also requires to make drag zones observable.

tobiu referenced in commit abf3019 - "draggable.DragZone: fire events on itself when drop related events arrive #1383" on Nov 4, 2020, 12:22 PM
tobiu
tobiu Nov 4, 2020, 12:30 PM

changed the logic, so that the dom event manager fires the events on the matching drag zone and this one subscribes to them directly as well.

tobiu referenced in commit 2687251 - "#1383 changed the logic, so that the dom event manager fires the events on the matching drag zone and this one subscribes to them directly as well" on Nov 4, 2020, 12:30 PM
tobiu
tobiu Nov 4, 2020, 12:47 PM

hmm, i actually like the implementation with 3 listeners less better. it is a tick faster, since you don't need to fetch the handlers from the observable anyway.

tobiu referenced in commit 1a2c7f5 - "#1383 back to the implementation with 3 listeners less" on Nov 4, 2020, 12:48 PM
tobiu closed this issue on Nov 4, 2020, 1:23 PM