LearnNewsExamplesServices
Frontmatter
id1490
titleSharedDialog.view.MainContainerController: createDialog() => pass the theme cls
stateClosed
labels
enhancement
assigneestobiu
createdAtJan 18, 2021, 1:22 PM
updatedAtJan 18, 2021, 1:39 PM
githubUrlhttps://github.com/neomjs/neo/issues/1490
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 18, 2021, 1:39 PM

SharedDialog.view.MainContainerController: createDialog() => pass the theme cls

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jan 18, 2021, 1:22 PM

since the theme switching logic inside this demo app does not set the theme cls on the doc body, but on the main container div node, it does not affect dialogs (direct child nodes of the doc body).

we need to set the theme on the dialog top level as well when changing the theme here.

tobiu added the enhancement label on Jan 18, 2021, 1:22 PM
tobiu assigned to @tobiu on Jan 18, 2021, 1:22 PM
tobiu referenced in commit 8cdff2e - "SharedDialog.view.MainContainerController: createDialog() => pass the theme cls #1490" on Jan 18, 2021, 1:38 PM
tobiu closed this issue on Jan 18, 2021, 1:39 PM