LearnNewsExamplesServices
Frontmatter
id15015
titleVisual harness substrate + scope-floor-v1 goldens (delivered leaf of the baseline harness program)
stateClosed
labels
enhancementdeveloper-experienceai
assigneesneo-opus-grace
createdAt2:22 AM
updatedAt2:37 AM
githubUrlhttps://github.com/neomjs/neo/issues/15015
authorneo-opus-grace
commentsCount0
parentIssue14618
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAt2:37 AM

Visual harness substrate + scope-floor-v1 goldens (delivered leaf of the baseline harness program)

Closed Backlog/active-chunk-5 enhancementdeveloper-experienceai
neo-opus-grace
neo-opus-grace commented on 2:22 AM

Context

Review convergence on PR #15007 (the #14618 visual-regression harness): the delivered head ships the harness SUBSTRATE and four deterministic goldens, but #14618's full scope floor also names a token-demo-surface golden and one AgentCard per STATE — and the committed seed roster only exercises ok/idle/off. Per the honest close-target discipline, this ticket is the narrow delivered-scope child; #14618 stays open for the remainder.

Delivered scope (this ticket, closed by PR #15007)

  • The named visual Playwright config: forced reducedMotion, project-level viewport that is mechanically effective (after the device spread — the review caught the dead top-level declaration silently mis-sizing every golden), reuseExistingServer: false (a design-authority suite renders only ITS OWN checkout), reviewed-refresh-only semantics (--update-snapshots).
  • The rebuild-before-baseline invariant as a run-failing globalSetup (tree-wide SCSS-vs-built-CSS mtime; it convicted three genuinely stale trees on its first night).
  • Four committed goldens at the effective 1600×900 viewport: default cockpit shell, fleet grid, activity chip row, and the Accounts surface (inheriting the golden orphaned by PR #14998's spec reshaping, per the design-gate disposition there).
  • Determinism proven per refresh: a generation run followed by a clean pass against the committed goldens.

Remainder (stays on #14618)

  • One AgentCard golden per STATE in the full vocabulary (needs a harness-scoped fixture seam — the PRODUCT seed roster must stay honest, so state-variant fixtures cannot be smuggled into it).
  • The token-demo-surface golden (its canonical page is the consumer leaf's own deliverable; capturing a placeholder would violate the design-regression-not-content-churn rule).
  • The shell golden's first reviewed refresh now that the preset bar merged.

Acceptance Criteria

  • PR #15007's delivered set (config + guard + four goldens + determinism evidence) merged with this ticket as its truthful close target.
  • #14618 remains open carrying the remainder above.

Related

Parent #14618 (the program) · PR #15007 (the delivery) · PR #14998 (the inherited Accounts golden's provenance) · #14560 (the epic; the SSOT-governed-visuals closeout row).

Live latest-open sweep: checked this hour's filings; the two adjacent convergence children (#15008, #15014) cover different PRs; no equivalent. A2A sweep: clean.

Origin Session ID: ef6b9a4a-54ec-4afb-8438-f89a3ee46ad2 Retrieval Hint: "visual harness substrate scope floor goldens delivered leaf"

tobiu closed this issue on 2:37 AM