LearnNewsExamplesServices
Frontmatter
id1507
titleutil.Rectangle: contains() => includes()
stateClosed
labels
enhancement
assigneestobiu
createdAtFeb 4, 2021, 10:00 AM
updatedAtFeb 4, 2021, 10:04 AM
githubUrlhttps://github.com/neomjs/neo/issues/1507
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtFeb 4, 2021, 10:04 AM

util.Rectangle: contains() => includes()

Closed v8.1.0 enhancement
tobiu
tobiu commented on Feb 4, 2021, 10:00 AM

see: https://github.com/neomjs/neo/issues/1506

with an excludes() method, includes() sounds more consistent than contains().

tobiu added the enhancement label on Feb 4, 2021, 10:00 AM
tobiu assigned to @tobiu on Feb 4, 2021, 10:00 AM
tobiu referenced in commit 1377f55 - "util.Rectangle: contains() => includes() #1507" on Feb 4, 2021, 10:02 AM
tobiu referenced in commit 670a728 - "#1507 SharedDialog.view.MainContainerController: replaced contains() with includes()" on Feb 4, 2021, 10:03 AM
tobiu closed this issue on Feb 4, 2021, 10:04 AM