LearnNewsExamplesServices
Frontmatter
id15141
titleKeep the external PR checklist out of agent-authored bodies
stateClosed
labels
documentationenhancementaimodel-experience
assigneesneo-gpt-emmy
createdAt1:31 AM
updatedAt1:49 AM
githubUrlhttps://github.com/neomjs/neo/issues/15141
authorneo-gpt-emmy
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAt1:49 AM

Keep the external PR checklist out of agent-authored bodies

Closed Backlog/active-chunk-5 documentationenhancementaimodel-experience
neo-gpt-emmy
neo-gpt-emmy commented on 1:31 AM

Context

During the operator review of agent-authored PR #15133, the PR body was found to contain the generic change-kind, breaking-change, base-branch, and feature-rationale checklist from .github/PULL_REQUEST_TEMPLATE.md. The same duplication is present on open PR #15140.

That static repository template is intentional: it is an optional aid for external contributors. This ticket does not remove or redesign it. It makes the agent workflow's separate body contract explicit so agent-authored PRs stop copying the external checklist.

Live latest-open sweep: checked the latest 20 open issues at 2026-07-13T23:31:29.549Z; no equivalent ticket or recent in-flight A2A claim was found.

The Problem

The pull-request skill already requires an outcome summary, deltas from the ticket, evidence, test results, post-merge validation, and authorship. Appending the optional external checklist adds a second, weaker metadata layer:

  • change kind duplicates the PR title, ticket labels, and prose;
  • the breaking-change checkbox is less informative than the required delta/evidence narrative;
  • the target branch is a live GitHub fact and is already mechanically prescribed as dev;
  • “a convincing reason” duplicates the ticket premise and PR outcome summary.

The extra block makes agent PR bodies longer without adding decision-grade evidence, and it obscures the graph-ingestion anchors that are actually required.

The Architectural Reality

  • .github/PULL_REQUEST_TEMPLATE.md:16-37 owns the optional external-contributor checklist and remains unchanged.
  • .agents/skills/pull-request/references/pull-request-workflow.md:269-325 owns agent PR body hygiene and the minimum-viable agent body.
  • .github/workflows/agent-pr-body-lint.yml:57-63 enforces the substantive agent anchors; it does not require the external checklist.
  • PR #15133 and PR #15140 are live examples of the unwanted copy.
  • The workflow payload is conditionally loaded only when the pull-request skill fires; the top-level SKILL.md router does not need to grow.

The Fix

Rewrite the existing opening sentence in pull-request workflow §9 so it says that agent-authored PR bodies must not copy either:

  1. the ticket body; or
  2. the optional external-contributor .github/PULL_REQUEST_TEMPLATE.md.

The sentence must still direct authors to summarize the implementation delta using the required agent structure below it. Keep the rewrite byte-neutral or net-negative. Do not add a second rule block, new template file, or new lint mechanism.

Contract Ledger

Target surface Source of authority Proposed behavior Fallback / failure Docs Evidence
agent-authored PR body pull-request-workflow.md §9 use the agent minimum body only; do not append the optional external checklist missing substantive anchors continues to fail existing PR-body lint rewrite existing hygiene sentence skill lint + live #15140 body cleanup
external-contributor PR body .github/PULL_REQUEST_TEMPLATE.md remains available and optional external authors may omit or complete it as before unchanged zero diff on the static template
always-loaded skill router .agents/skills/pull-request/SKILL.md no change n/a unchanged zero router-byte delta

Decision Record impact

none — this clarifies the existing split between the external contributor template and the agent pull-request workflow.

Acceptance Criteria

  • Pull-request workflow §9 explicitly excludes the optional external-contributor template from agent-authored PR bodies.
  • The clarification rewrites the existing sentence instead of adding a new section, with a byte-neutral or net-negative workflow delta.
  • .github/PULL_REQUEST_TEMPLATE.md remains unchanged.
  • The agent minimum-viable PR-body structure and current CI anchors remain unchanged.
  • Open agent-authored PR #15140 is truth-synced by removing the copied external checklist.
  • node ai/scripts/lint/lint-skill-manifest.mjs --base origin/dev passes.

Out of Scope

Redesigning the external contributor template · retroactively editing merged PR bodies · changing PR-body lint anchors · changing branch policy · changing review templates.

Avoided Traps

  • Do not “fix” the external contributor experience by deleting its optional template.
  • Do not duplicate the full external template inside the skill as a negative example.
  • Do not add a new lint for prose that one precise workflow sentence can prevent.

Related

Related: #15133 · #15135 · PR #15140

Origin Session ID: f95e01ff-ba36-409a-98af-573263fab247

Retrieval Hint: agent PR body optional external contributor checklist pull-request workflow hygiene

tobiu referenced in commit ff6d587 - "docs(agentos): separate agent and external PR bodies (#15141) (#15142)" on 1:49 AM
tobiu closed this issue on 1:49 AM