LearnNewsExamplesServices
Frontmatter
id1527
titleSharedDialog.view.MainContainerController: switchThemeForApp() => use the doc.body
stateClosed
labels
enhancement
assigneestobiu
createdAtMar 10, 2021, 1:00 PM
updatedAtMar 10, 2021, 1:00 PM
githubUrlhttps://github.com/neomjs/neo/issues/1527
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMar 10, 2021, 1:00 PM

SharedDialog.view.MainContainerController: switchThemeForApp() => use the doc.body

Closed v8.1.0 enhancement
tobiu
tobiu commented on Mar 10, 2021, 1:00 PM

rather than applying the new theme to the main div node of each app, we should add it to the document body instead.

the reason is that the divs needed for dialog show & hide animations get directly added to the document.body. so, changing the theme on a div on the same DOM tree level won't affect them.

tobiu added the enhancement label on Mar 10, 2021, 1:00 PM
tobiu assigned to @tobiu on Mar 10, 2021, 1:00 PM
tobiu referenced in commit 4731168 - "SharedDialog.view.MainContainerController: switchThemeForApp() => use the doc.body #1527" on Mar 10, 2021, 1:00 PM
tobiu closed this issue on Mar 10, 2021, 1:00 PM