LearnNewsExamplesServices
Frontmatter
id1738
titlemodel.Component: resolveFormatter() => keep the generated function as minimal as possible
stateClosed
labels
enhancement
assigneestobiu
createdAtApr 9, 2021, 3:08 PM
updatedAtApr 9, 2021, 3:09 PM
githubUrlhttps://github.com/neomjs/neo/issues/1738
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 9, 2021, 3:09 PM

model.Component: resolveFormatter() => keep the generated function as minimal as possible

Closed v8.1.0 enhancement
tobiu
tobiu commented on Apr 9, 2021, 3:08 PM

@bhaustein mentioned that it would be nicer to move the

if (!data) {
    data = this.getHierarchyData();
}

part out of the generated fn. Since we are only calling it inside resolveFormatter() I agree.

tobiu added the enhancement label on Apr 9, 2021, 3:08 PM
tobiu assigned to @tobiu on Apr 9, 2021, 3:08 PM
tobiu referenced in commit 9cc52ce - "model.Component: resolveFormatter() => keep the generated function as minimal as possible #1738" on Apr 9, 2021, 3:09 PM
tobiu closed this issue on Apr 9, 2021, 3:09 PM