LearnNewsExamplesServices
Frontmatter
id1764
titlecomponent.Base: _controller => store the instance
stateClosed
labels
enhancement
assigneestobiu
createdAtApr 13, 2021, 11:06 PM
updatedAtApr 13, 2021, 11:07 PM
githubUrlhttps://github.com/neomjs/neo/issues/1764
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 13, 2021, 11:07 PM

component.Base: _controller => store the instance

Closed v8.1.0 enhancement
tobiu
tobiu commented on Apr 13, 2021, 11:06 PM

right now _controller contains the controller id and beforeGetController() resolves the instance.

we can remove this lookup and store the instance directly (same way as _model).

component.Base: destroy() will destroy the controller anyway, so there should not be any memory leaks.

tobiu added the enhancement label on Apr 13, 2021, 11:06 PM
tobiu assigned to @tobiu on Apr 13, 2021, 11:06 PM
tobiu referenced in commit ddc7e76 - "component.Base: _controller => store the instance #1764" on Apr 13, 2021, 11:07 PM
tobiu closed this issue on Apr 13, 2021, 11:07 PM