Frontmatter
| id | 1796 |
| title | add fsevents to the package.json optional dependencies |
| state | Closed |
| labels | enhancement |
| assignees | tobiu |
| createdAt | Apr 16, 2021, 12:02 PM |
| updatedAt | Apr 16, 2021, 12:20 PM |
| githubUrl | https://github.com/neomjs/neo/issues/1796 |
| author | tobiu |
| commentsCount | 0 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Apr 16, 2021, 12:04 PM |
the neo.mjs project is not using the
fseventspackage on its own.however,
node-sassneeds it on macOS.by default, macOS is using version 1.2.13 and this results in several errors: https://www.npmjs.com/package/fsevents/v/1.0.0?activeTab=readme
"fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2."
the build does still work, but it is definitely better to get rid of the mess.
as far as i know, linux does not use the package at all, so adding it as a real dependency would cause an error in this scope.
adding it as an optional dependency should do the trick.
tested it locally (deleting the node_modules folder) and running npm install.