LearnNewsExamplesServices
Frontmatter
id18135
titleFive npm advisories on dev, all fixable in range — dependabot #18132 covers two
stateClosed
labels
bugaibuild
assigneesneo-opus-grace
createdAtSep 2, 2026, 9:12 PM
updatedAtSep 3, 2026, 3:56 PM
githubUrlhttps://github.com/neomjs/neo/issues/18135
authorneo-opus-grace
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtSep 3, 2026, 3:56 PM

Five npm advisories on dev, all fixable in range — dependabot #18132 covers two

neo-opus-grace
neo-opus-grace commented on Sep 2, 2026, 9:12 PM

Context

Dependency audit across the three org repos, 2026-09-02 (operator-requested: "npm outdated, also checking for new major versions"). The engine's half is the cheapest and the most valuable: five advisories, every one fixable inside the declared ranges.

The Problem

npm audit on dev:

package severity advisory in dependabot #18132?
browserslist high unbounded memory growth (no cache eviction) → eventual OOM yes
fast-uri high host confusion via skipped IDN canonicalization on scheme-relative refs yes
nanoid high custom generators can loop indefinitely when size is zero no
qs moderate array-limit bypass via bracket-key comma parsing no
body-parser low DoS when an invalid limit silently disables size enforcement no

Every row reports fixAvailable: true — in range, no breaking change. npm audit fix --dry-run completes and leaves the working tree clean.

Dependabot #18132 covers two of the five. Merging it and treating the engine as done leaves three open, one of them high. That PR is not wrong — it is partial, and it is the reason this ticket exists rather than a comment on it.

All five arrive through transitive dev dependencies (build tooling and the dev server), so there is no runtime exposure in a published neo.mjs consumer. That is why this is not urgent; it is not why it should be skipped.

The Fix

One lockfile refresh that closes all five, superseding #18132 rather than stacking on it:

  1. npm audit fix on dev, lockfile only.
  2. Re-run the full suites — this touches build tooling, so unit and components are the evidence, not a diff read.
  3. Close #18132 as superseded, citing this PR.

Acceptance Criteria

  • AC-1 npm audit reports 0 vulnerabilities at any severity on the resulting dev.
  • AC-2 package.json is unchanged — the fix is entirely package-lock.json. A change to a declared range means a major crept in and the PR is the wrong shape.
  • AC-3 unit and components green at the head, run locally as well as in CI: the packages are build tooling, so a green diff proves nothing about the build.
  • AC-4 #18132 closed as superseded with a pointer, so the two do not race in the merge queue.

Out of Scope — the majors, deliberately

npm outdated also offers three major bumps, all devDependencies, none security-driven:

  • chalk 5.6.2 → 6.0.0
  • inquirer 13.4.3 → 14.2.0
  • monaco-editor 0.50.0 → 0.56.0 (six 0.x minors — breaking by convention)

They belong in their own ticket with their own evidence. Bundling a major into a security refresh is how a lockfile-only PR becomes unreviewable, and it would cost AC-2 its meaning.

Also out of scope: the sibling repos. The Brain's sharp/libvips chain has no fix available and needs a decision rather than a bump; institution runs js-yaml 4 while this repo and the Brain run 5. Both are filed separately in their own repos.

Avoided Traps

  • Reading blast radius as value. I told @tobiu earlier today that #18132 "buys us nothing tonight", assessed purely on its being lockfile-only and dev-transitive. That answers how risky is landing it, not what does it buy — and the instrument that answers the second question is npm audit, which I had not run. Same PR, same risk, two high advisories.
  • Treating a dependabot PR as the whole answer. It groups what its own scanner grouped; the repo's advisory set is a different query.
  • Landing it before the rehearsal. Build tooling changes what the demo is built from. Nothing here is worth that on the night before.

Related

  • #18132 — the partial dependabot PR this supersedes.
  • neomjs/neo-agent-brain — the sharp/libvips decision (no fix available).
  • neomjs/neo-agent-institution — the js-yaml major skew.

Live latest-open sweep: read the latest 20 open issues at 2026-09-02T19:10:35Z; no dependency-audit ticket among them, and #18132 is the only adjacent artifact.

Origin Session ID: fb58e855-74b2-4367-9f83-5877f151f024

Retrieval Hint: "engine npm audit five advisories all in range, dependabot 18132 partial, browserslist fast-uri nanoid qs body-parser"