LearnNewsExamplesServices
Frontmatter
id1825
titlechange binding formatters from strings to functions
stateClosed
labels
enhancement
assigneestobiu
createdAtApr 20, 2021, 12:21 PM
updatedAtApr 20, 2021, 12:24 PM
githubUrlhttps://github.com/neomjs/neo/issues/1825
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 20, 2021, 12:24 PM

change binding formatters from strings to functions

Closed v8.1.0 enhancement
tobiu
tobiu commented on Apr 20, 2021, 12:21 PM

This is a rather big topic. Actually a breaking change, so this would be neo v2.

To get rid of our only know security issue: fn = new Function('data', 'return ' + formatter + ';');

we should replace binding formatter strings with functions.

While we can not convert a template literal to a string, we can definitely use myFunction.toString().

tobiu added the enhancement label on Apr 20, 2021, 12:21 PM
tobiu assigned to @tobiu on Apr 20, 2021, 12:21 PM
tobiu referenced in commit b9afdb7 - "change binding formatters from strings to functions #1825" on Apr 20, 2021, 12:22 PM
tobiu closed this issue on Apr 20, 2021, 12:24 PM