LearnNewsExamplesServices
Frontmatter
id1830
titlemodel.Component: getFormatterVariables() => use regex.replace()
stateClosed
labels
enhancement
assignees[]
createdAtApr 20, 2021, 2:06 PM
updatedAtApr 20, 2021, 2:24 PM
githubUrlhttps://github.com/neomjs/neo/issues/1830
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 20, 2021, 2:24 PM

model.Component: getFormatterVariables() => use regex.replace()

Closed v8.1.0 enhancement
tobiu
tobiu commented on Apr 20, 2021, 2:06 PM

follow up ticket for #1829

we need to replace part.match(dataVariableRegex) with part.replace(dataVariableRegex, "data$2")

to ensure that the vm code can access the data properties.

tobiu added the enhancement label on Apr 20, 2021, 2:06 PM
tobiu
tobiu Apr 20, 2021, 2:23 PM

replace() was a bad idea, since it replaces the match content instead of parts of the content.

we can still do it.

tobiu referenced in commit b2fb5d3 - "#1830 model.Component: getFormatterVariables() => remove the variable content up to the first dot." on Apr 20, 2021, 2:24 PM
tobiu closed this issue on Apr 20, 2021, 2:24 PM