LearnNewsExamplesServices
Frontmatter
id1866
titleverify if public class fields work now using webpack based builds
stateClosed
labels
enhancement
assigneestobiu
createdAtApr 25, 2021, 9:55 AM
updatedAtApr 25, 2021, 10:49 AM
githubUrlhttps://github.com/neomjs/neo/issues/1866
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtApr 25, 2021, 10:49 AM

verify if public class fields work now using webpack based builds

Closed v8.1.0 enhancement
tobiu
tobiu commented on Apr 25, 2021, 9:55 AM

not a perfect timing right after the v2 release, but just got an update on this topic: https://github.com/webpack/webpack/issues/10216#issuecomment-826144064

will do a quick test (upgraded to webpack v5.35.1).

tobiu added the enhancement label on Apr 25, 2021, 9:55 AM
tobiu assigned to @tobiu on Apr 25, 2021, 9:55 AM
tobiu referenced in commit 009920a - "#1866 multiWindow.ViewportController: changed one config to a public class field" on Apr 25, 2021, 9:56 AM
tobiu referenced in commit cc1c775 - "#1866 added the 2 multiWindow apps to the build.json" on Apr 25, 2021, 10:03 AM
tobiu referenced in commit 417b7ea - "#1866 build.json added the shared workers build setting" on Apr 25, 2021, 10:13 AM
tobiu referenced in commit 52c3ba8 - "#1866 multiWindow.ViewportController: cleanup" on Apr 25, 2021, 10:22 AM
tobiu
tobiu Apr 25, 2021, 10:49 AM

Screenshot 2021-04-25 at 10 27 11

Screenshot 2021-04-25 at 10 22 42

Screenshot 2021-04-25 at 10 25 50

this looks good!

tobiu closed this issue on Apr 25, 2021, 10:49 AM
tobiu referenced in commit 4a40a1a - "#1866 multiWindow.ViewportController: changed connectedApps into a public class field" on Apr 25, 2021, 12:34 PM
tobiu referenced in commit f9327a8 - "#1866 multiWindow.MainContainerController: changed dialog into a public class field" on Apr 25, 2021, 12:38 PM
tobiu referenced in commit 50537d1 - "#1866 removed a not need comma inside the index.html files" on Apr 25, 2021, 2:47 PM