LearnNewsExamplesConnect
Frontmatter
assigneesneo-opus-ada
createdAtSep 19, 2026, 7:31 PM
updatedAtSep 19, 2026, 8:46 PM
githubUrlhttps://github.com/neomjs/neo/issues/18992
authorneo-opus-ada
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtSep 19, 2026, 8:46 PM

Seven grid e2e specs each carry their own gridDriver loader

Closed v13.2.0/archive-v13-2-0-chunk-22 enhancementairefactoringtestinggrid
neo-opus-ada
neo-opus-ada commented on Sep 19, 2026, 7:31 PM

Context

@neo-fable released this as a claimable grid lane (A2A, 2026-09-19 16:02Z). Measured on dev@f0a9e0baa5: seven e2e specs load test/playwright/component/apps/grid-cell-editing/gridDriver.mjs through their own copy of one loader.

The Problem

Each copy is the same three lines: Neo.worker.App.loadModule({path}) on the driver URL, a per-file counter appended as &n= so every call is a new module URL rather than a cached import, and an expect(success) on the reply.

  • Six are named drive(page, action): CellEditingLockedBodies, CellEditingPooling, CellEditingReprojectionFocus, CellEditingRowModel, CellEditingStoreActivity, CellEditingToggle.
  • The seventh, LockedRegionEmpties' setLocked(page, field, locked), adds two query parameters to the same shape.

A change to the loader contract, such as the driver's path, the cache-busting rule or the failure message, has to be made seven times, and a copy that drifts fails only in the spec that carries it.

The Architectural Reality

  • test/playwright/e2e/utils/gridCellEditing.mjs already holds what these specs share (the cell, editor and embodiment reads), "so a change to it reddens both from one place".
  • The component tier's installCancelListener (component/grid/CellEditing.spec.mjs) loads a different module, cancelListenerDriver.mjs, and stays out of scope.

The Fix

One exported driveGrid(page, action, params) in e2e/utils/gridCellEditing.mjs, with a single counter and the query parameters built from params. The seven specs import it, and their local copies and counters go. The net diff is negative.

Acceptance Criteria

  • No e2e spec builds a gridDriver.mjs URL itself. git grep -n "gridDriver.mjs?" test/playwright/e2e names only the util.
  • The seven specs pass unchanged in what they assert (e2e/grid green), and the diff removes more lines than it adds.

Out of Scope

The driver module itself, the component tier's cancel-listener loader, and any assertion change.

Related

#18762 (the closed epic whose specs these are)

Live latest-open sweep: the latest 20 open issues at 2026-09-19T17:31Z, none equivalent. Searches for gridDriver and "drive helper" across all states found nothing on this. A2A sweep: Fable's 16:02Z release, and no claim since. MC sweep: "grid cell editing e2e specs duplicate drive helper gridDriver loadModule shared util" names it as a candidate (Fable, 09-19); no prior decision. Own-assignment sweep: none overlapping. Decision Record impact: none.

Origin Session ID: 6ecb7b5f-dc26-48a3-8e49-7232159377c1

tobiu referenced in commit db3de7d - "test(grid): the grid e2e specs share one gridDriver loader (#18992) (#18993)" on Sep 19, 2026, 8:46 PM
tobiu closed this issue on Sep 19, 2026, 8:46 PM