LearnNewsExamplesServices
Frontmatter
id19388
titleADR 0038 §2.5.1: the Fleet''s observe read gets a class row, and the one seat PAT is declared
stateClosed
labels
documentationenhancementaiarchitectureagent-os
assigneesneo-opus-ada
createdAtOct 3, 2026, 9:01 PM
updatedAtOct 4, 2026, 3:01 AM
githubUrlhttps://github.com/neomjs/neo/issues/19388
authorneo-opus-ada
commentsCount0
parentIssue823
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtOct 4, 2026, 3:01 AM

ADR 0038 §2.5.1: the Fleet's observe read gets a class row, and the one seat PAT is declared

Closed v13.2.0/archive-v13-2-0-chunk-24 documentationenhancementaiarchitectureagent-os
neo-opus-ada
neo-opus-ada commented on Oct 3, 2026, 9:01 PM

Context

This is the ADR half of neomjs/neo-agent-brain#823, FM v1 row 4's planner-accepted gap 3. Its AC-1 requires that this amendment, read by Emmy, merges before the Brain implementation PR opens. The planner's product answer (Clio, 2026-10-03 18:13Z): the installed Fleet reads GitHub with the one PAT the operator gave at Add Agent, with no second token, no new field, no credential step.

The Problem

ADR 0038 §2.5.1 (the credential-class ledger) is out of step with what ships, in two places:

  1. The Fleet's observe read has no row. The Fleet's open-work producer reads the team's pull requests from the forge, and on Brain dev@5d46661 it takes its token from the process environment (devFleetServer.mjs:486 → readGithubToken()). That borrows class 4's GH_TOKEN shape from whatever process launched the Fleet. A Fleet started from Finder or the Dock has none, so the installed FM shows no PR events (row 4's walk, steps 2–4).
  2. The one seat PAT is undeclared. The ledger says a seat holds classes 3 (its MCP bearer to the plane) and 4 (its repository-workflow PAT) "as distinct mints". Since neomjs/neo-agent-brain#818, under the operator's one-PAT ruling of 2026-10-03, one seat PAT serves both. The ledger's rule is "no silent substitution", so the reuse must be written down.

The Architectural Reality

  • The ledger: learn/agentos/decisions/0038-fm-client-topology.md §2.5 / §2.5.1, with its six rows and the non-alias rule on every row. It was last amended by #19370 (§2.2's ownerPrincipal → the plane-governed forge connection).
  • The credential owner: the seat PAT is held in the Fleet's store and served Brain-side by FleetRegistryService.resolveCredential(id). That is the accessor #818's first Start uses (startAgentProvisioned.mjs:241).

The Fix

  1. Add a row, the Fleet observe read (Fleet → forge, read-only). Recommended design: per-seat scoping. Each seat's own open work (its authored and held pull requests) is read with that seat's PAT.
    • Coverage is partial and names any seat without a readable PAT, plus its next step.
    • The process environment remains an explicit override for headless and dev runs, never the installed default.
    • The rejected alternative goes to §4: one designated PAT reading the whole team. It is a new team-wide identity substitution, and it silently loses private repositories that identity cannot see.
    • The final choice is settled in the PR with Emmy's read.
  2. Declare the one seat PAT. One sentence on rows 3 and 4: a Fleet-managed seat's class 3 and class 4 are served by the single PAT the operator gives at Add Agent (#818). It is a declared reuse, so the non-alias rule holds for every other pair.
  3. Bookkeeping: §2.5's "six distinct classes" becomes seven, and the header's Amended line names this change.

Acceptance Criteria

  • §2.5.1 has a seventh row for the Fleet's observe read, with all nine columns, a non-alias cell that forbids one seat's PAT reading another seat's work, and the process-environment override bounded to headless/dev.
  • Rows 3 and 4 declare the single seat PAT under the one-PAT ruling, citing #818.
  • §4 records the rejected alternative with its reason.
  • Emmy, as enrollment steward, reads the PR before merge.

Out of Scope

The producer's implementation (neomjs/neo-agent-brain#823 itself). The Activity pane's words for a missing source (row 2, #477).

Related

Parent outcome: neomjs/neo-agent-brain#823 (row 4, Institution #414). Prior amendment: #19370. neomjs/neo-agent-brain#818 (the seat PAT at first Start).

Sweeps: live latest-open neo sweep, 20 issues at 2026-10-03T19:00:57Z, plus a search for "ADR 0038 2.5.1": no equivalent. A2A: my lane-claim on #823 (18:50Z); no competing claim. Memory Core: no prior decision on the producer's credential source (#823 intake).

Decision Record impact: amends ADR 0038.

Origin Session ID: 84371353-afea-4f59-9b58-2b8777325f56 Retrieval Hint: "ADR 0038 credential class ledger Fleet observe read per-seat PAT one seat PAT class 3 class 4 declared reuse"

tobiu referenced in commit fe6029f - "docs(adr): ADR 0038 §2.5.1 gains the Fleet's observe read and declares the one seat PAT (#19388) (#19389) on Oct 4, 2026, 3:01 AM
tobiu closed this issue on Oct 4, 2026, 3:01 AM