LearnNewsExamplesConnect
Frontmatter
assigneesneo-fable-mnemosyne
createdAtOct 10, 2026, 7:25 PM
updatedAtOct 10, 2026, 7:42 PM
githubUrlhttps://github.com/neomjs/neo/issues/19562
authorneo-fable-mnemosyne
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtOct 10, 2026, 7:42 PM

Grid header text grows in windows under 600 px wide, popups included

neo-fable-mnemosyne
neo-fable-mnemosyne commented on Oct 10, 2026, 7:25 PM

Context

The operator's v13.2 hand check (#14800, step 2, 2026-10-10 17:2xZ): a Workstation grid torn out into its own window (458×471 outer, the size PR #19559 gives it) shows its header text visibly larger than the same grid docked in the main window, while the body cells stay the same. His read: the docked size is the wanted one, at every window width.

The Problem

resources/scss/src/grid/header/Button.scss lines 122–131: the header's .neo-button-text takes var(--grid-header-button-font-size) (13 px in neo-dark, 11 px in neo-light), but under @media (max-width: 600px) it switches to var(--button-text-font-size), which is --core-fontsize-label = 1rem = 16 px. The query reads the window width: a 458 px popup counts as a phone, the same 458 px pane inside a 1254 px window does not, so the header grows from 13 to 16 px the moment a pane leaves the room.

The rule came from #6419 (d64f6fc67c, 2025-02-09), whose text says the opposite of what the rule does today: "The font-size does get increased a bit for default buttons, but this should not happen for the grid scope." resources/scss/src/button/Base.scss line 114 changes default button text to 13 px under the same query; the grid header's counter-rule was meant to keep the header out of that change, and it points at the larger size instead.

The Architectural Reality

  • Neo.grid.header.Button extends Neo.button.Base, so Base's .neo-button .neo-button-text media rule reaches the header text. The header file needs its own rule under the same query to win regardless of stylesheet order (equal specificity).
  • Window-width media queries in the engine SCSS: button/Base.scss:114, toolbar/Base.scss:9, component/Markdown.scss:12, app/content/PageContainer.scss:16, grid/header/Button.scss:128. A torn-out vessel is a narrow window by design (its outer size equals the pane's), so every one of these fires in a popup that a docked pane never triggers. This ticket fixes the one the operator saw; the rest is a product read, listed under Out of Scope.
  • Design authority: #6419, "this should not happen for the grid scope", and the operator on 2026-10-10: the smaller, docked header size is the one he wants.

The Fix

resources/scss/src/grid/header/Button.scss: inside the @media (max-width: 600px) block, font-size: var(--grid-header-button-font-size) instead of var(--button-text-font-size), with the comment stating why the block exists (Base changes default button text on narrow windows; the header keeps its own size). No theme file changes.

Acceptance Criteria

  • A component spec reads the header button text's computed font-size at a 1100 px and at a 500 px wide viewport: equal, and equal to the computed --grid-header-button-font-size.
  • Post-merge, the operator's hand: a torn-out Workstation grid shows the docked header size.

Out of Scope

  • The other four window-width rules (toolbar, Markdown, PageContainer, default button text). Whether a narrow popup should ever count as a phone is a product decision for a separate ticket.
  • Any token or rem change.

Related

#19559 / #19450 (the popup now has the pane's size, which exposed this) · #14800 (cut order, step 2) · #6419 (the rule's origin) · #8035 (the header font-size variable)

Live latest-open sweep: the latest 20 open issues at 17:25Z, no equivalent (#19515 is grid keyboard navigation). A2A: no claim on this scope in the last hour. Memory Core: #8035 (2025-12-05) introduced --grid-header-button-font-size; no decision on the 600 px rule found. Own open tickets: none on this surface.

Origin Session ID: 656ab1e8-7b9c-4a10-b370-8718db430fad

Retrieval Hint: "grid header font-size popup window max-width 600 media query button-text-font-size"

tobiu referenced in commit 7c4b227 - "fix(grid): the header text keeps its own font-size in windows under 600 px wide (#19562) (#19563) on Oct 10, 2026, 7:42 PM
tobiu closed this issue on Oct 10, 2026, 7:42 PM