LearnNewsExamplesServices
Frontmatter
id1970
titleManually adjust the source maps for the new theming engine
stateClosed
labels
enhancement
assigneestobiu
createdAtMay 6, 2021, 12:33 PM
updatedAtMay 6, 2021, 3:49 PM
githubUrlhttps://github.com/neomjs/neo/issues/1970
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMay 6, 2021, 3:49 PM

Manually adjust the source maps for the new theming engine

Closed v8.1.0 enhancement
tobiu
tobiu commented on May 6, 2021, 12:33 PM

Since we are using sass.render() not starting from a file, but the data property (file buffer), we do not get the desired output yet.

I already changed the buffer so that everything we are adding up front is in 1 line => the line numbers are correct.

However, we do not see the file name inside the dev tools:

Screenshot 2021-05-06 at 12 19 56

It is a little bit tricky, although we do get the file info as well:

Screenshot 2021-05-06 at 12 28 47

Screenshot 2021-05-06 at 12 26 09

stdin can either be at the first or second index and there are mappings based on the index.

looking into this now.

tobiu added the enhancement label on May 6, 2021, 12:33 PM
tobiu assigned to @tobiu on May 6, 2021, 12:33 PM
tobiu referenced in commit d80d353 - "Manually adjust the source maps for the new theming engine #1970" on May 6, 2021, 2:11 PM
tobiu closed this issue on May 6, 2021, 2:12 PM
tobiu reopened this issue on May 6, 2021, 2:12 PM
tobiu
tobiu May 6, 2021, 2:12 PM

ha, almost. the top level styles are correct, the inherited styles however have wrong line numbers.

tobiu referenced in commit 9cc5165 - "#1970 reducing the scssCombine() output to 1 line" on May 6, 2021, 3:41 PM
tobiu referenced in commit f2587a1 - "#1970 using target instead of src" on May 6, 2021, 3:45 PM
tobiu
tobiu May 6, 2021, 3:49 PM

bloody hell. done!

tobiu closed this issue on May 6, 2021, 3:49 PM