LearnNewsExamplesConnect
Frontmatter
assigneesJah-yee
createdAtOct 21, 2026, 2:26 PM
updatedAtOct 21, 2026, 3:24 PM
githubUrlhttps://github.com/neomjs/neo/issues/19952
authorneo-opus-grace
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtOct 21, 2026, 3:24 PM

Right-clicking a header menu's arrow opens the browser's context menu

Closed v13.3.1/archive-v13-3-1-chunk-1 bughelp wantedgood first issuehacktoberfestaigrid
neo-opus-grace
neo-opus-grace commented on Oct 21, 2026, 2:26 PM

Context

An outside user tried the 13.3.0 issues showcase after the release announcement, and the operator relayed the report on 2026-10-21. With a column's value menu open, right-clicking the header's arrow shows the browser's own context menu (Back, Forward, Reload…) on top of the value menu.

Reproduced on neomjs.com 13.3.0, at dist/production/examples/grid/issues/index.html. A contextmenu event dispatched on the State header button is default-prevented, so no browser menu appears. The same event on that header's arrow (.neo-grid-menu-trigger) is not.

The Problem

#19643 lets a header open its value menu with a right-click. The arrow is part of that same control, yet a right-click on it falls through to the browser. That puts two menus on screen at once.

The Architectural Reality

  • src/grid/header/plugin/Menu.mjs:90 adds neo-grid-menu-enabled to the header button.
  • Menu.mjs:119-122 registers that class as a contextmenu default-prevention target through Neo.main.DomEvents.registerPreventDefaultTargets.
  • src/main/DomEvents.mjs:539 prevents the default only when the event path contains a registered class.
  • The header's vdom is wrapped (src/grid/header/Button.mjs:366, .neo-grid-menu-wrapper). The arrow is created with the wrapper as its parent (Menu.mjs:93), which makes it the button's sibling. Its event path therefore never contains the button, or neo-grid-menu-enabled.

The Fix

Make a right-click on the arrow behave like one on the header:

  • the browser menu stays closed, either by also registering neo-grid-menu-trigger as a contextmenu target or by moving the class to the wrapper;
  • the value menu opens, or stays open.

Check which component the plugin's contextmenu listener reaches when the event starts on the arrow.

Acceptance Criteria

  • AC-1: A right-click on a header's arrow never shows the browser's context menu, and it opens the value menu, or keeps it open, as a right-click on the header does.
  • AC-2: Headers without a value menu are unchanged. Their behaviour is decided separately.
  • AC-3: A browser test proves AC-1 and fails on dev. test/playwright/e2e/grid/IssuesShowcase.spec.mjs runs the showcase in the engine tier, without the Neural Link, and can read the event's defaultPrevented.

Out of Scope

Right-click on headers that have no value menu (that is a separate ticket), and the menu's content.

Related: #19643 (header menus) · #19761 (the showcase) Live latest-open sweep: the latest 20 open issues, read at 2026-10-21T12:25Z; no equivalent. gh search issues for "context menu header" returned nothing. A2A claim sweep: the last 12 messages, all read-states; no claim on the header menus. unowned-rationale: reserved for an outside contributor, like the release-testing day's examples (#19930–#19934). It is small, located to two files, and has a browser-test pointer.

Retrieval Hint: "header menu arrow right click browser context menu preventDefault target" Origin Session ID: ccf66974-a439-4e14-ba8c-4f3f74d87606

tobiu assigned to @Jah-yee on Oct 21, 2026, 2:39 PM
tobiu referenced in commit 2abc17f - "fix(grid): keep the browser menu away on a header arrow right-click (#19952) (#19959) on Oct 21, 2026, 3:24 PM
tobiu closed this issue on Oct 21, 2026, 3:24 PM