LearnNewsExamplesServices
Frontmatter
id19975
titleclaim-responder.yml drops queued burst claims and reads stale issue state
stateClosed
labels
bugcontributor-experienceaibuild
assigneesneo-gemini-julia
createdAtOct 22, 2026, 12:23 AM
updatedAtOct 22, 2026, 12:41 AM
githubUrlhttps://github.com/neomjs/neo/issues/19975
authorneo-gemini-julia
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtOct 22, 2026, 12:41 AM

claim-responder.yml drops queued burst claims and reads stale issue state

Closed Backlog/active-chunk-10 bugcontributor-experienceaibuild
neo-gemini-julia
neo-gemini-julia commented on Oct 22, 2026, 12:23 AM

Context

Design authority: CONTRIBUTING.md:107 ("Drop a short comment saying you're taking it (Claiming this is enough) and open your pull request within 7 days; the repo replies right away to confirm whether the issue is yours or already taken") and neomjs/neo#19202.

Live latest-open sweep: checked latest 20 open issues in neomjs/neo at 2026-10-21T22:22:53Z (#19973, #19971, #19930, #19919, #19855, ..., #19136); no equivalent found. A2A in-flight claim sweep: checked list_messages({status: 'all', limit: 30}) at 2026-10-21T22:22:57Z; no competing claim on neomjs/neo/.github/workflows/claim-responder.yml. Memory Core rationale sweep: queried query_raw_memories({query: 'claim-responder.yml queue max refresh issue state', nResults: 3}) (20cd0887-ca63-42e1-b4b8-8de8d283bc56, 46c2e123-45b2-4f4b-a9ff-7cc2286ab43b, d23970c1-88cf-49cb-98b8-d5e32a09278b); surfaced @neo-gpt-sophie's Round-1 review findings on neomjs/neo-agent-brain#1242 (5606649179) and neomjs/neo-agent-institution#781 (5606649464). Own-assignment sweep: checked gh issue list --repo neomjs/neo --state open --assignee @me (#19971, which scopes buildScripts/util/claimResponse.mjs regex patterns only).

The Problem

During Round-1 review of neomjs/neo-agent-brain#1242 (5606649179) and neomjs/neo-agent-institution#781 (5606649464), @neo-gpt-sophie identified two reliability defects in .github/workflows/claim-responder.yml that were originally inherited from neomjs/neo/.github/workflows/claim-responder.yml:

  1. Pending claim events are dropped on burst claims (concurrency missing queue: max): .github/workflows/claim-responder.yml:20-22 sets group: claim-responder-${{ github.event.issue.number }} and cancel-in-progress: false without queue: max. Under GitHub Actions' default queue: single semantics, if run A is active, run B is pending, and claimant C comments on the same issue, GitHub cancels pending run B, so claimant B never receives a reply.
  2. Queued runs pass stale context.payload.issue state to decideReply: .github/workflows/claim-responder.yml:48-79 reads issue from context.payload (captured when the comment event fired) rather than fetching the current issue via github.rest.issues.get. If an issue is closed, loses its good first issue / help wanted label, or is assigned while a run waits in the concurrency queue, the queued run still evaluates the stale unassigned/open payload and can post a false "first in line" reply.

Both fixes are now merged in neomjs/neo-agent-brain#1242 and approved in neomjs/neo-agent-institution#781, leaving neomjs/neo/.github/workflows/claim-responder.yml drifted.

The Architectural Reality

  • neomjs/neo/.github/workflows/claim-responder.yml:20-22 defines the concurrency: block for issue_comment runs on neomjs/neo.
  • neomjs/neo/.github/workflows/claim-responder.yml:46-87 runs actions/github-script@v9, imports curatedLabel and decideReply from buildScripts/util/claimResponse.mjs, queries comments/PRs/candidate issues, and posts the reply comment.

The Fix

Update .github/workflows/claim-responder.yml in neomjs/neo to match neomjs/neo-agent-brain/.github/workflows/claim-responder.yml:

  1. Add queue: max under concurrency: (.github/workflows/claim-responder.yml:20-23).
  2. Rename context.payload.issue to eventIssue, fetch the live issue via const {data: issue} = await github.rest.issues.get({owner, repo, issue_number: eventIssue.number}), return early with core.info('No reply: issue is no longer an open curated issue.') when issue.state !== 'open' || !label, and pass the refreshed issue (and label) to search.issuesAndPullRequests and decideReply.

Contract Ledger Matrix

Target Surface Source of Authority Proposed Behavior Fallback Docs Evidence
.github/workflows/claim-responder.yml (concurrency + Answer the claim step) CONTRIBUTING.md:107, neomjs/neo-agent-brain#1242 (5606649179), buildScripts/util/claimResponse.mjs:139-227 Sets concurrency.queue: max to retain pending burst claims in FIFO order, and refreshes issue via github.rest.issues.get before decideReply, suppressing replies if the issue was closed or decurated while queued and passing current issue.assignees to decideReply. Returns early without posting a comment if !body or if the refreshed issue is closed or no longer carries a curated label. CONTRIBUTING.md:107 YAML parse + embedded callback replay across 3-claimant FIFO burst (A, B, C) and 4 queued state-change scenarios (closed, decurated, assigned-to-other, assigned-to-claimant)

Decision Record impact

none

Acceptance Criteria

  • AC-1: .github/workflows/claim-responder.yml includes queue: max alongside cancel-in-progress: false under concurrency:.
  • AC-2: .github/workflows/claim-responder.yml refreshes the issue via await github.rest.issues.get({owner, repo, issue_number: eventIssue.number}), suppresses replies when issue.state !== 'open' || !curatedLabel(issue), and passes the refreshed issue to decideReply.
  • AC-3: Controlled replay of the embedded github-script callback verifies the 3-claimant FIFO burst (A, B, C) and the 4 queued state-mutation cases (closed-while-queued, decurated-while-queued, assigned-to-other-while-queued, assigned-to-claimant-while-queued).

Out of Scope

  • Modifying buildScripts/util/claimResponse.mjs (covered by neomjs/neo#19971 / PR #19972).

Avoided Traps

  • Relying on context.payload.issue in a queued workflow: Job-level if: guards evaluate against the event snapshot at trigger time; once runs queue behind an active run on the same issue, only a fresh github.rest.issues.get read inside the job sees closure, label removal, or assignment changes that happened while waiting.

Related

  • neomjs/neo#19971 / PR neomjs/neo#19972
  • neomjs/neo-agent-brain#1241 / PR neomjs/neo-agent-brain#1242
  • neomjs/neo-agent-institution#780 / PR neomjs/neo-agent-institution#781

Origin Session ID: fd51794e-dcdf-4240-a11c-75e32cb5e357 Retrieval Hint: "claim-responder.yml queue max github.rest.issues.get refresh issue state"

tobiu referenced in commit 7f3b73a - "fix(build): preserve queued burst claims and refresh issue state (#19975) (#19976)" on Oct 22, 2026, 12:41 AM
tobiu closed this issue on Oct 22, 2026, 12:41 AM