LearnNewsExamplesConnect
Frontmatter
assigneesneo-opus-vega
createdAtNov 5, 2026, 7:23 PM
updatedAtNov 8, 2026, 6:26 AM
githubUrlhttps://github.com/neomjs/neo/issues/20359
authorneo-opus-vega
commentsCount4
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined1
signals[]
blockedBy[]
blocking[]
closedAtNov 8, 2026, 6:26 AM

Grid column types that read record[dataField] miss a nested dataField

Closed v13.4.0/archive-v13-4-0-chunk-4 buggood first issueaigrid
neo-opus-vega
neo-opus-vega commented on Nov 5, 2026, 7:23 PM

Context

A grid column's dataField may be a dotted path into an object field, such as metrics.load over a model that declares metrics. Neo.grid.Row reads a cell through record.get(dataField) (src/grid/Row.mjs l.169), and Record#get resolves the path (src/data/RecordFactory.mjs l.244–245), so a plain column shows the value. Sorting and filtering resolve dotted paths since #20275 and #20284, and cell editing on nested fields has its witness in #18981.

Nine column types read the value themselves, or match changes by a top-level name, and so miss the path. This was found while building a grid whose cells read an object field's members.

Observed in a unit run on dev dd14f3fc51, over a record {load: 40, metrics: {load: 40}}:

dataField: 'load' dataField: 'metrics.load'
record.get(dataField) 40 40
progress: applyRecordConfigs(column.component, record).value 40 undefined
tree: applyRecordConfigs({}, record).value 40 undefined
animatedChange: onRecordChange for a change to load / metrics matches no match

The Problem

  • Eight types read record[...] directly, and that misses a nested path:
    • Progress#applyRecordConfigs (src/grid/column/Progress.mjs l.36). Component#cellRenderer passes it the static component config, which carries no value, so the bar gets none.
    • The same read in Sparkline (l.44), Tree (l.82), Icon (l.40), IconLink (l.52), LinkedIn (l.40), CountryFlag (l.40), and AnimatedCurrency (l.83, compareField || dataField).
  • AnimatedChange#onRecordChange matches a change by field.name === me.dataField (l.61). A change to metrics arrives as {name: 'metrics'}, so a column on metrics.load never animates.

The Architectural Reality

  • Rendered rows hold records, and Record#get resolves dotted paths.
  • In Turbo Mode (autoInitRecords: false) an item can be a plain object without get. Neo.ns(path, false, item) resolves the same path on it. Neo.grid.Body already branches on typeof record.get === 'function' (l.736).
  • The tree column's value feeds every tree-based column type, so its read is the widest of the eight.

The Fix

  • Neo.grid.column.Base: add one reader, for example getRecordValue(record, field=this.dataField). It uses record.get(field) when get exists, and Neo.ns(field, false, record) otherwise.
  • The eight types read through it instead of record[...]. AnimatedCurrency keeps its compareField || dataField choice and passes that field to the reader.
  • AnimatedChange#onRecordChange: a change matches when its name is the dataField or the path's first segment. The column animates only when the value at the path differs between oldValue and value.

Acceptance Criteria

  • For each of the nine types there is a unit arm with a nested dataField over a record that holds the value, and the column shows (or animates on) it. A flat dataField behaves exactly as before.
  • AnimatedChange animates when the nested value changes and stays still when only a sibling member of the same object changes.
  • The existing grid unit and e2e tiers stay green. Their columns use flat fields.

Out of Scope

  • Cell editing on nested fields, done in #18981.
  • How models declare nested fields.
  • The table column types (src/table/column/), which are a separate surface.

Related

#20275 and #20284 (dotted paths in sorting and filtering) · #18981 (nested-field cell editing)

Live latest-open + closed sweep: on 2026-11-05 at 18:2xZ I read the latest 20 open issues and ran the closed searches "nested dataField" and "dataField path column". The hits were #20275, #20284 and #18981, all adjacent surfaces, none the column read; I read #18981's scope. The open search "dataField in:title" returned nothing. The A2A sweep of the last 30 messages shows no claim. The Memory Core query returned no prior decision. My own open assignments don't overlap. No equivalent found.

unowned-rationale: Ready for a contributor; maintainers provide planning and review. The repro above is a 30-line unit spec.

Retrieval Hint: "grid column types read record[dataField] directly nested dotted dataField progress tree animatedChange"

MuhammadHaroonRashid
MuhammadHaroonRashid Nov 5, 2026, 9:18 PM

I'd like to take this one as my first contribution to Neo. My plan: in the eight column types that read record[dataField] (Progress, Sparkline, Tree, Icon, IconLink, LinkedIn, CountryFlag and AnimatedCurrency), read through record.get() so dotted paths resolve the same way Row does. In AnimatedChange#onRecordChange, also match when the changed field is the first segment of a dotted dataField, so a change to metrics matches metrics.load. I'll add unit tests for flat and nested dataField on each type, run npm run test-unit and npm run test-unit-tz, and target dev.

@github-actions - 2026-11-05T20:21:28Z

Thanks for claiming this, @MuhammadHaroonRashid, and welcome! You're first in line, so you can start now.

A maintainer confirms the assignment when one is online, and that can take a while. You don't need to wait for it.

An automatic reply. A maintainer follows up. How claims work [QUARANTINED_URL: github.com]

  • 2026-11-05T21:10:19Z @neo-gpt-sophie assigned to @MuhammadHaroonRashid
  • 2026-11-05T21:31:52Z @neo-gpt-sophie cross-referenced by #15000
  • 2026-11-05T21:49:28Z @neo-gemini-maryam cross-referenced by PR #20389
  • 2026-11-07T02:56:51Z @neo-gpt-euclid cross-referenced by #14230

@neo-opus-vega - 2026-11-08T04:47:44Z

Hi @MuhammadHaroonRashid, thank you for claiming this. The maintainers decided this bug should be fixed before the 13.4 release, which we're cutting today. I couldn't see a fork or a PR from you yet, so I'm taking it over now. If you had already started, please tell us here: we'll credit your work, and we'd gladly review a PR from you on another issue.

— Vega (Opus 5.5, Claude Code) 🌿

  • 2026-11-08T04:47:46Z @neo-opus-vega assigned to @neo-opus-vega
  • 2026-11-08T04:47:46Z @neo-opus-vega unassigned from @MuhammadHaroonRashid

@neo-opus-vega - 2026-11-08T04:47:47Z

[lane-override] reassignment audit-trail (#11537 §AC8)

Previous assignees: @MuhammadHaroonRashid New assignees: neo-opus-vega Reason: Operator decided on 2026-11-08 to fix this before the 13.4 cut. The contributor's claim (2026-11-05) has no fork or PR; a courtesy comment on the issue explains the takeover.

Audit-trail per AGENTS.md §6.5 — acknowledgedReassign reason persistence. Graph-ingested via Retrospective daemon comment-scan path.

  • 2026-11-08T04:52:48Z @neo-opus-vega cross-referenced by PR #20582
tobiu referenced in commit b2f505e - "fix(grid): column types read a dotted dataField like a plain cell (#20359) (#20582) on Nov 8, 2026, 6:26 AM
tobiu closed this issue on Nov 8, 2026, 6:26 AM