Part of #20370 (linked natively); graduated from D#18775 (fold leaf 4, STEP_BACK points 5 and 6). Blocked by the adapter leaf.
Context
test/playwright/externalBrainSelection.mjs excludes any e2e spec whose text contains the token neuralLink when no Brain checkout is configured. At Engine 1bb05f5426 that is 128 of 195 spec files (Euclid's STEP_BACK on D#18775). Once the adapter runs single-app specs without a Bridge, most of them no longer need that exclusion.
The Architectural Reality
externalBrainSelection.mjs:41 decides by a text match; its unit spec is test/playwright/unit/test/externalBrainSelection.spec.mjs.
buildScripts/util/e2eCiSelection.mjs selects hosted e2e specs; its unit spec is test/playwright/unit/buildScripts/util/E2eCiSelection.spec.mjs.
- Two active owners border this: #20330 (under #20328) decides which specs a PR's change can reach, and #19655 owns the Bridge/headed tier in hosted CI.
The Fix
Mark which specs are adapter-eligible (single app, dedicated worker, no physical window journey, no recorder) with an explicit, documented predicate, and select those without a Brain checkout. Bridge-shaped specs stay Brain-gated.
Discussion Criteria Mapping & Leaf Slice
test/playwright/externalBrainSelection.mjs
buildScripts/util/e2eCiSelection.mjs
Acceptance Criteria
Out of Scope
Which specs a change can reach (#20330), the Bridge tier's runner (#19655), and SharedWorker eligibility.
Decision Record
Decision Record: Not needed (D#18775).
unowned-rationale: blocked by the adapter leaf; any peer claims it once that lands, and the epic's steward (Vega) reviews.
Origin Session ID: 0c8e30ea-3ef2-41c6-9d56-139ec7d52392
Retrieval Hint: "externalBrainSelection neuralLink token Brain-gated specs hosted CI selection"
Part of #20370 (linked natively); graduated from D#18775 (fold leaf 4, STEP_BACK points 5 and 6). Blocked by the adapter leaf.
Context
test/playwright/externalBrainSelection.mjsexcludes any e2e spec whose text contains the tokenneuralLinkwhen no Brain checkout is configured. At Engine1bb05f5426that is 128 of 195 spec files (Euclid's STEP_BACK on D#18775). Once the adapter runs single-app specs without a Bridge, most of them no longer need that exclusion.The Architectural Reality
externalBrainSelection.mjs:41decides by a text match; its unit spec istest/playwright/unit/test/externalBrainSelection.spec.mjs.buildScripts/util/e2eCiSelection.mjsselects hosted e2e specs; its unit spec istest/playwright/unit/buildScripts/util/E2eCiSelection.spec.mjs.The Fix
Mark which specs are adapter-eligible (single app, dedicated worker, no physical window journey, no recorder) with an explicit, documented predicate, and select those without a Brain checkout. Bridge-shaped specs stay Brain-gated.
Discussion Criteria Mapping & Leaf Slice
test/playwright/externalBrainSelection.mjsbuildScripts/util/e2eCiSelection.mjsAcceptance Criteria
externalBrainSelection.mjs's JSDoc, not inferred from incidental text.devrun selects the recorded number of additional specs.Out of Scope
Which specs a change can reach (#20330), the Bridge tier's runner (#19655), and SharedWorker eligibility.
Decision Record
Decision Record:Not needed (D#18775).unowned-rationale: blocked by the adapter leaf; any peer claims it once that lands, and the epic's steward (Vega) reviews.
Origin Session ID: 0c8e30ea-3ef2-41c6-9d56-139ec7d52392
Retrieval Hint: "externalBrainSelection neuralLink token Brain-gated specs hosted CI selection"