LearnNewsExamplesConnect
Frontmatter
assigneesneo-opus-grace
createdAtNov 8, 2026, 7:09 PM
updatedAtNov 8, 2026, 7:59 PM
githubUrlhttps://github.com/neomjs/neo/issues/20595
authorneo-opus-grace
commentsCount1
parentIssue20328
subIssues[]
subIssuesCompleted0
subIssuesTotal0
contentTrust
projected
quarantined0
signals[]
blockedBy[]
blocking[]
closedAtNov 8, 2026, 7:48 PM

The components tier starts three runners only to report a skip

Closed v13.4.0/archive-v13-4-0-chunk-4 enhancementaiperformancebuild
neo-opus-grace
neo-opus-grace commented on Nov 8, 2026, 7:09 PM

Context

The organization runs on 20 concurrent job slots, and every repository's pull requests share them. A runner booted only to report a skip is a slot another pull request waits for. Epic #20328 holds an Engine PR push to the slots its diff needs. #20338 gave unit, e2e-engine and e2e-brain job-level skips. Its intake (#20338 comment 6665796895) left components for later, because skipping a sharded tier also changes its required contexts.

That is not a choice between shapes. A skipped matrix never reports its per-shard contexts, so under the cap the tier needs one aggregate context. #17171 binds the guards the same way.

The Problem

test.yml's test job is a three-shard matrix with no job-level if:. Each shard gates its steps on matrix.run, so a PR the classifier rules out of the tier still boots three runners. Each runner only verifies the head and prints a skip. Measured on #20574 (docs only, head 35fd47a0ec): components (1/3), (2/3) and (3/3) each held a runner for about 5 s, and every test step was skipped.

A job-level if: alone would strand those PRs. The dev ruleset requires each shard by name: components (1/3), (2/3) and (3/3) (GET /repos/neomjs/neo/rules/branches/dev, 2026-11-08T18:06Z). A matrix skipped before expansion reports one check under its unexpanded name. On the same head, that check is e2e-engine (${{ matrix.shard }}/${{ matrix.shards }}). So no components (n/3) context would ever report.

The Architectural Reality

  • .github/workflows/test.yml test: matrix include of three components entries. Its name: and artifact name still carry the tzLabel and suite generality the timezone probes needed before #20355 moved them into unit.
  • .github/workflows/test-e2e.yml e2e-engine + e2e-engine-gate: the shape to copy. The shards skip at job level. The gate (if: always(), needs: [changes, e2e-engine]) reports the one required context. It accepts skipped only on an explicit run_e2e=false from a successful classifier.
  • .github/workflows/classify-test-scope.yml emits run_components and skip_reason. A stale head sets every run flag to false with its reason.
  • test/playwright/unit/buildScripts/util/WorkflowScopeClassifier.spec.mjs holds the e2e tier to that shape: job if:, head-gated steps, and the gate script executed across every verdict.

The Fix

  1. The matrix job, renamed components, skips at job level unless run_components is 'true' and a dispatch probe selects no other suite. Its steps drop the matrix.run and dead suite/tz arms and keep the head gate.
  2. A components-gate job named components, in the e2e-engine-gate shape, reports the tier's one context.
  3. WorkflowScopeClassifier.spec.mjs gains the two e2e arms for the components tier, red on dev first.
  4. Ruleset (operator, at merge): components (1/3), (2/3) and (3/3) out, components in. #17171's baseline swap needs an edit at the same moment, so one edit can carry both.

Contract Ledger

Target surface Source of authority Proposed behavior Fallback Docs Evidence
Required context of the components tier ruleset 19087298 (operator) One components context from the gate: green when every shard passed, or when a successful classifier ruled the tier out None; the shard contexts leave the ruleset in the same edit test.yml job comments Live ruleset read above
Shard checks components (n/3) test.yml Reported when the tier runs. One skipped check under the unexpanded name when it doesn't n/a n/a e2e-engine (${{ matrix.shard }}/${{ matrix.shards }}) on #20574

Acceptance Criteria

  • AC-1: The matrix job skips at job level on a ruled-out verdict, and every step that spends the runner stays gated on the live head. A spec holds both, red on dev.
  • AC-2: The components gate passes skipped shards only on run_components=false from a successful classifier. It passes run shards only when all succeeded. Every other combination fails. A spec executes the gate script across those verdicts, red on dev.
  • AC-3: The PR body records the check names GitHub reports on the PR's own head.
  • AC-4 (post-merge): The first ruled-out PR after the merge starts no components runner, and its components context is green with the classifier's reason.
  • AC-5 (post-merge, operator): The ruleset swap is shown by gh api repos/neomjs/neo/rules/branches/dev output.

Out of Scope

  • The classifier's run_components predicate (#20329, #20330).
  • The baseline's contexts and the guard workflows (#17171).
  • Shard count and balance (#18916).

Avoided Traps

  • A job-level if: without a gate: every ruled-out PR waits forever on three contexts that never report.
  • Keeping per-shard required contexts beside the gate: every change to the shard count would need a ruleset edit.
  • A gate that reads skipped as a pass by itself: a failed classifier also leaves skipped shards. The gate has to tell the two apart, as e2e-engine-gate does.

Related

Parent #20328 · deferred from #20338 · #17171 (the Decision; the same ruleset edit) · #20355 (moved the timezone probes into unit) · #18916 (sharded the tier).

Decision Record impact: none (aligned with #17171's Decision).

Live latest-open + closed sweep: latest 20 open, plus a closed search ("components shard skipped runner context"; Out of Scope read on #20338 and #16248), A2A claims over the last 30 messages, and Memory Core on the problem nouns, at 2026-11-08T18:08Z. No equivalent or prior exclusion found.

Owner: @neo-opus-grace, self-assigned because the ruleset edit has to be timed with #17171's before the 13.4 cut.

Origin Session ID: 963e0574-17e9-435e-becf-3f3e26c395ce Retrieval Hint: "components shards runners skip aggregate gate ruleset components (1/3) #20338 #20328"

tobiu referenced in commit d17300f - "ci(components): a ruled-out components tier starts no runner, behind one context (#20595) (#20596)" on Nov 8, 2026, 7:48 PM
tobiu closed this issue on Nov 8, 2026, 7:48 PM