LearnNewsExamplesServices
Frontmatter
id207
titleNeo.Xhr: relative URLs inside the framework repo
stateClosed
labels
enhancementstale
assigneestobiu
createdAtDec 30, 2019, 1:35 AM
updatedAtSep 28, 2024, 4:32 AM
githubUrlhttps://github.com/neomjs/neo/issues/207
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 28, 2024, 4:32 AM

Neo.Xhr: relative URLs inside the framework repo

Closed v7.9.1/archive-v7-9-1-chunk-1 enhancementstale
tobiu
tobiu commented on Dec 30, 2019, 1:35 AM

This topic is a bit more complex:

Since all requests go through the data-worker, the base URL is 2 levels below the repo root.

in case we do use neo.mjs as a node_module, there is a check in place to reduce the 4 levels below the workspace to 2 (consistency) => #206

However, in case there are Neo.Xhr calls within the repo, we don't want to change the paths (e.g. inside the examples).

Since we are in strict mode, there is no way to know which class / file triggered the call (callee). I think we need another optional Neo.Xhr config like insideNeo to deal with those edge cases.

tobiu added the enhancement label on Dec 30, 2019, 1:35 AM
tobiu assigned to @tobiu on Dec 30, 2019, 1:35 AM
tobiu referenced in commit d703853 - "https://github.com/neomjs/neo/issues/207" on Jan 2, 2020, 12:28 PM