LearnNewsExamplesServices
Frontmatter
id2129
titleform.Fieldset: disableItemsOnCollapse_ config
stateClosed
labels
enhancement
assigneestobiu
createdAtMay 23, 2021, 9:26 AM
updatedAtMay 23, 2021, 11:13 AM
githubUrlhttps://github.com/neomjs/neo/issues/2129
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMay 23, 2021, 11:13 AM

form.Fieldset: disableItemsOnCollapse_ config

Closed v8.1.0 enhancement
tobiu
tobiu commented on May 23, 2021, 9:26 AM

in case you are working with forms, you can either improve the UX when fieldsets are collapsible or you might want to exclude fieldset items from getting submitted in case the fieldset is collapsed.

we need a new config to make it optional.

tobiu added the enhancement label on May 23, 2021, 9:26 AM
tobiu assigned to @tobiu on May 23, 2021, 9:26 AM
tobiu referenced in commit d04e8df - "form.Fieldset: disableItemsOnCollapse_ config #2129" on May 23, 2021, 10:27 AM
tobiu
tobiu May 23, 2021, 10:30 AM

to further enhance this:

We need a map to store the initial disabled state of fieldset items. E.g. a map (object) with key {componentId}, value (disabledState).

In case we collapse a fieldset and a childItem is already disabled, it needs to be disabled when expanding the fieldset again.

tobiu
tobiu May 23, 2021, 10:35 AM

actually an array is better => only store disabled item ids.

tobiu referenced in commit 7cc7950 - "form.Fieldset: disableItemsOnCollapse_ config #2129" on May 23, 2021, 10:46 AM
tobiu referenced in commit 7dbfdad - "#2129 form.Fieldset: cleanup, changed a field to disabled inside the demo app" on May 23, 2021, 10:53 AM
tobiu closed this issue on May 23, 2021, 11:13 AM