LearnNewsExamplesServices
Frontmatter
id2195
titlecomponent.Base: smarter handling of styles
stateClosed
labels
enhancement
assigneestobiu
createdAtMay 29, 2021, 12:08 AM
updatedAtMay 29, 2021, 12:09 AM
githubUrlhttps://github.com/neomjs/neo/issues/2195
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMay 29, 2021, 12:09 AM

component.Base: smarter handling of styles

Closed v8.1.0 enhancement
tobiu
tobiu commented on May 29, 2021, 12:08 AM

updateStyle() is using vnode.vnode.style = style;. This can cause bugs, since vdom pseudo-style attributes are possible (e.g. height:10). we need an iteration.

render() should not need to pass cls or style.

the vdom setter should not need to apply style configs each time.

tobiu added the enhancement label on May 29, 2021, 12:08 AM
tobiu assigned to @tobiu on May 29, 2021, 12:08 AM
tobiu referenced in commit 4c0e61e - "component.Base: smarter handling of styles #2195" on May 29, 2021, 12:09 AM
tobiu closed this issue on May 29, 2021, 12:09 AM