LearnNewsExamplesServices
Frontmatter
id2396
titlevdom.Helper: createDeltas() => ensure there are no move OPs to the same index
stateClosed
labels
enhancementstale
assigneestobiu
createdAtJun 18, 2021, 12:43 AM
updatedAtSep 16, 2024, 4:36 AM
githubUrlhttps://github.com/neomjs/neo/issues/2396
authortobiu
commentsCount3
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 16, 2024, 4:36 AM

vdom.Helper: createDeltas() => ensure there are no move OPs to the same index

Closed v8.1.0 enhancementstale
tobiu
tobiu commented on Jun 18, 2021, 12:43 AM

this does not cause any bugs, but triggers a not needed dom OP.

            if (movedNode) {

                // todo: check if there is a real index change

                deltas.push({
                    action: 'moveNode',
                    id      : oldVnode.id,
                    index   : movedNode.index,
                    parentId: movedNode.parentNode.id
                });
tobiu added the enhancement label on Jun 18, 2021, 12:43 AM
tobiu assigned to @tobiu on Jun 18, 2021, 12:43 AM
tobiu
tobiu Jun 18, 2021, 12:44 AM

this should also get added to the latest calendar siesta test.

@github-actions - 2024-09-01T02:38:39Z

This issue is stale because it has been open for 90 days with no activity.

  • 2024-09-01T02:38:39Z @github-actions added the stale label

@github-actions - 2024-09-16T02:36:56Z

This issue was closed because it has been inactive for 14 days since being marked as stale.

  • 2024-09-16T02:36:56Z @github-actions closed this issue