LearnNewsExamplesServices
Frontmatter
id2564
titleRefactoring: list.Menu => menu.Panel
stateClosed
labels
enhancement
assigneestobiu
createdAtJul 6, 2021, 1:28 PM
updatedAtJul 6, 2021, 7:41 PM
githubUrlhttps://github.com/neomjs/neo/issues/2564
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJul 6, 2021, 7:41 PM

Refactoring: list.Menu => menu.Panel

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jul 6, 2021, 1:28 PM

It is more flexible to use container.Panel as the base class, in case someone would want to add headers / footers to menus.

The panel needs to contain the list as a child item.

tobiu added the enhancement label on Jul 6, 2021, 1:28 PM
tobiu assigned to @tobiu on Jul 6, 2021, 1:28 PM
tobiu referenced in commit 9ca450b - "#2564 menu.Panel: base class" on Jul 6, 2021, 1:33 PM
tobiu referenced in commit 8f72448 - "#2564 list.Menu => menu.List" on Jul 6, 2021, 1:36 PM
tobiu referenced in commit 688d8d0 - "#2564 list.Menu => menu.List => scss" on Jul 6, 2021, 1:43 PM
tobiu referenced in commit 7ed77eb - "#2564 menu.List => adjusted the example" on Jul 6, 2021, 1:48 PM
tobiu referenced in commit 2e611a1 - "#2564 menu.Panel: list_, listConfig" on Jul 6, 2021, 1:52 PM
tobiu referenced in commit c2280fe - "#2564 menu.Panel: beforeSetList()" on Jul 6, 2021, 1:57 PM
tobiu referenced in commit 902d389 - "#2564 menu.Panel: afterSetList()" on Jul 6, 2021, 1:59 PM
tobiu referenced in commit effbfa3 - "#2564 examples.menu.panel" on Jul 6, 2021, 2:04 PM
tobiu referenced in commit 61595dd - "#2564 menu.Panel: afterSetList()" on Jul 6, 2021, 2:06 PM
tobiu referenced in commit 81fa9d4 - "#2564 menu.Panel: styling" on Jul 6, 2021, 2:42 PM
tobiu referenced in commit f5054b2 - "#2564 menu.List: adjusted the scss var names (menu => menu-list)" on Jul 6, 2021, 2:44 PM
tobiu referenced in commit 61bf7ed - "#2564 menu.Model" on Jul 6, 2021, 2:47 PM
tobiu referenced in commit 458e434 - "#2564 menu.Model: doc comments" on Jul 6, 2021, 2:49 PM
tobiu referenced in commit d298be4 - "#2564 menu.Store" on Jul 6, 2021, 2:53 PM
tobiu referenced in commit febd8da - "#2564 menu.List: using menu.Store" on Jul 6, 2021, 2:57 PM
tobiu referenced in commit ee6b531 - "#2564 examples.menu.panel.MainStore: extending menu.Store" on Jul 6, 2021, 3:01 PM
tobiu referenced in commit 3effae1 - "#2564 examples.menu.list.MainStore: extending menu.Store" on Jul 6, 2021, 3:03 PM
tobiu referenced in commit b14abb5 - "#2564 menu.Panel: menuItems_ config & logic" on Jul 6, 2021, 3:16 PM
tobiu closed this issue on Jul 6, 2021, 7:41 PM