LearnNewsExamplesServices
Frontmatter
id264
titleRemove buildScripts/webpack/entrypoints/App.mjs
stateClosed
labels
enhancement
assigneestobiu
createdAtMar 12, 2020, 12:27 PM
updatedAtMar 12, 2020, 12:39 PM
githubUrlhttps://github.com/neomjs/neo/issues/264
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtMar 12, 2020, 12:39 PM

Remove buildScripts/webpack/entrypoints/App.mjs

tobiu
tobiu commented on Mar 12, 2020, 12:27 PM

The only reason this override-file exists was Firefox parsing dynamic imports at build-time instead of run time.

            if (!Neo.config.isExperimental) {
                Neo.onStart();

                if (Neo.config.hash) {
                    HashHistory.push(Neo.config.hash, Neo.config.hashString);
                }
            } else {
                // todo: in case FF still does not support dynamic imports, remove the dynamic import call for FF dev builds

                import(
                    /* webpackIgnore: true */
                    '../../' + me.data.path).then((module) => {
                        Neo.onStart();

                        if (Neo.config.hash) {
                            HashHistory.push(Neo.config.hash, Neo.config.hashString);
                        }
                    }
                );
            }

=> this import() broke the dist versions, although the code was not reachable.

Luckily, this is no longer the case, so we can remove the file now and adjust the entrypoints.

tobiu added the enhancement label on Mar 12, 2020, 12:27 PM
tobiu assigned to @tobiu on Mar 12, 2020, 12:27 PM
tobiu referenced in commit 1ebf6b9 - "Remove buildScripts/webpack/entrypoints/App.mjs #264" on Mar 12, 2020, 12:32 PM
tobiu referenced in commit a88edb0 - "Remove buildScripts/webpack/entrypoints/App.mjs #264: adjusted the createApp script to point to the default app worker" on Mar 12, 2020, 12:37 PM
tobiu
tobiu Mar 12, 2020, 12:39 PM

done.

tobiu closed this issue on Mar 12, 2020, 12:39 PM