LearnNewsExamplesServices
Frontmatter
id2785
titlecomponent.Base:getDomRect() => convenience shortcut
stateClosed
labels
enhancement
assigneestobiu
createdAtJan 1, 2022, 1:02 PM
updatedAtJan 1, 2022, 1:48 PM
githubUrlhttps://github.com/neomjs/neo/issues/2785
authortobiu
commentsCount1
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJan 1, 2022, 1:46 PM

component.Base:getDomRect() => convenience shortcut

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jan 1, 2022, 1:02 PM

We are using Neo.main.DomAccess.getBoundingClientRect() 30+ times inside the src folder and there are more occurences inside the apps folder, so a convenience shortcut feels needed.

tobiu added the enhancement label on Jan 1, 2022, 1:02 PM
tobiu assigned to @tobiu on Jan 1, 2022, 1:02 PM
tobiu referenced in commit cc7019c - "Neo.getDomRect() => convenience shortcut #2785" on Jan 1, 2022, 1:03 PM
tobiu
tobiu Jan 1, 2022, 1:07 PM

thinking more about it, we should move the shortcut into component.Base, since this allows us to use default values for appName and id.

tobiu referenced in commit 28dfd37 - "#2785 moved the logic into component.Base" on Jan 1, 2022, 1:07 PM
tobiu referenced in commit 2252b63 - "#2785 testing the logic inside the calendar week view" on Jan 1, 2022, 1:10 PM
tobiu referenced in commit b2ab6a5 - "#2785" on Jan 1, 2022, 1:14 PM
tobiu referenced in commit 3c89cb6 - "#2785" on Jan 1, 2022, 1:32 PM
tobiu referenced in commit a6d742c - "#2785 => src folder" on Jan 1, 2022, 1:40 PM
tobiu changed title from Neo.getDomRect() => convenience shortcut to component.Base:getDomRect() => convenience shortcut on Jan 1, 2022, 1:40 PM
tobiu referenced in commit c6f4618 - "#2785 => shared covid app" on Jan 1, 2022, 1:43 PM
tobiu closed this issue on Jan 1, 2022, 1:46 PM