LearnNewsExamplesServices
Frontmatter
id3188
titlemain.mixin.DeltaUpdates: changing node attributes
stateClosed
labels
enhancement
assigneestobiu
createdAtJun 23, 2022, 2:45 PM
updatedAtJun 23, 2022, 2:46 PM
githubUrlhttps://github.com/neomjs/neo/issues/3188
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtJun 23, 2022, 2:46 PM

main.mixin.DeltaUpdates: changing node attributes

Closed v8.1.0 enhancement
tobiu
tobiu commented on Jun 23, 2022, 2:45 PM

so far, neo was using: node[key] = val;

this works fine for many attributes, but i just ran into edge cases where it does not (only tested in chrome). minlength and maxlength did not get applied using this strategy.

node.setAttribute(key, val); works fine for these edge-cases as well, so i will change it.

hopefully there are no side-effects, otherwise we will need to create follow-up tickets.

tobiu added the enhancement label on Jun 23, 2022, 2:45 PM
tobiu assigned to @tobiu on Jun 23, 2022, 2:45 PM
tobiu referenced in commit 12ae25c - "main.mixin.DeltaUpdates: changing node attributes #3188" on Jun 23, 2022, 2:46 PM
tobiu closed this issue on Jun 23, 2022, 2:46 PM