Frontmatter
| id | 3269 |
| title | Multi-window scope: adding support for re-opening an app |
| state | Closed |
| labels | enhancement |
| assignees | tobiu |
| createdAt | Jul 6, 2022, 11:29 AM |
| updatedAt | Jul 9, 2022, 11:48 AM |
| githubUrl | https://github.com/neomjs/neo/issues/3269 |
| author | tobiu |
| commentsCount | 5 |
| parentIssue | null |
| subIssues | [] |
| subIssuesCompleted | 0 |
| subIssuesTotal | 0 |
| blockedBy | [] |
| blocking | [] |
| closedAt | Jul 9, 2022, 11:48 AM |
Multi-window scope: adding support for re-opening an app
tobiu assigned to @tobiu on Jul 6, 2022, 11:29 AM
tobiu
Jul 6, 2022, 11:29 AM
@Dinkh
Dinkh
Jul 6, 2022, 11:38 AM
This is a bug, not an enhancement🐞 👍
tobiu
Jul 6, 2022, 12:22 PM
i would actually stick to enhancement, but it depends on the definition.
- bug: an implemented feature does not work as expected
- enhancement: a feature is not implemented yet
gray zone for this one i guess :)
Dinkh
Jul 6, 2022, 12:53 PM
Enhancement: Now you can even reopen a window Bug: I expect to even reopen the window
I would tend to bug, but from the naming of the ticket it is an enhancement ;)
tobiu
Jul 9, 2022, 11:48 AM
the "bug-feature" is resolved now. enjoy.
tobiu closed this issue on Jul 9, 2022, 11:48 AM
Inside e.g. the shared covid dashboard, we can expand views like the helix into new browser windows.
this does work fine for the first opening => we get a new app name and the theme map will store flags for added css files (delta updates). closing the helix and displaying it correctly works as well, since the original window already contains the required css.
however, in case we expand the helix into a new window again (using the same app name), the css won't get added, since the flags inside the map are already set.
we need a new algorithm to remove an app from the theme map and we should trigger it when destroying an app (inside the shared workers context).