LearnNewsExamplesServices
Frontmatter
id3461
titlebutton.Base: rippleEl wrapper
stateClosed
labels
enhancement
assigneestobiu
createdAtSep 28, 2022, 5:29 PM
updatedAtSep 28, 2022, 6:00 PM
githubUrlhttps://github.com/neomjs/neo/issues/3461
authortobiu
commentsCount0
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 28, 2022, 6:00 PM

button.Base: rippleEl wrapper

Closed v8.1.0 enhancement
tobiu
tobiu commented on Sep 28, 2022, 5:29 PM

right now, the top level CSS selector for buttons uses overflow: hidden.

we need this for ripple effects, but it collides with badges, which are supposed to be positioned absolutely over a corner.

so, we need a wrapper for ripples to resolve this.

tobiu added the enhancement label on Sep 28, 2022, 5:29 PM
tobiu assigned to @tobiu on Sep 28, 2022, 5:29 PM
tobiu referenced in commit edfeba5 - "button.Base: rippleEl wrapper #3461" on Sep 28, 2022, 5:44 PM
tobiu referenced in commit 2bc9420 - "#3461 removing the rippleWrapper again when needed" on Sep 28, 2022, 5:52 PM
tobiu referenced in commit 44e1488 - "#3461 added z-indexes to ensure the ripple effect is "behind" the content" on Sep 28, 2022, 5:58 PM
tobiu referenced in commit 6f9adc8 - "#3461 vdom cleanup" on Sep 28, 2022, 6:00 PM
tobiu closed this issue on Sep 28, 2022, 6:00 PM