LearnNewsExamplesServices
Frontmatter
id3477
titlecomponent.Base: convert `cls` into a real config
stateClosed
labels
enhancement
assigneestobiu
createdAtSep 30, 2022, 1:15 AM
updatedAtSep 30, 2022, 10:14 PM
githubUrlhttps://github.com/neomjs/neo/issues/3477
authortobiu
commentsCount2
parentIssuenull
subIssues[]
subIssuesCompleted0
subIssuesTotal0
blockedBy[]
blocking[]
closedAtSep 30, 2022, 10:14 PM

component.Base: convert cls into a real config

Closed v8.1.0 enhancement
tobiu
tobiu commented on Sep 30, 2022, 1:15 AM

we probably need a wrapperCls config as well.

tobiu added the enhancement label on Sep 30, 2022, 1:15 AM
tobiu assigned to @tobiu on Sep 30, 2022, 1:15 AM
tobiu referenced in commit dc2b15e - "component.Base: convert cls into a real config #3477 (in progress)" on Sep 30, 2022, 1:16 AM
tobiu referenced in commit c708687 - "#3477 component.Base: afterSetWrapperCls() logic" on Sep 30, 2022, 3:29 PM
tobiu referenced in commit 6bc9bf5 - "#3477 component.Base: afterSetWrapperCls() cleanup" on Sep 30, 2022, 3:30 PM
tobiu referenced in commit dc0b667 - "#3477 layout.Card: using wrapperCls" on Sep 30, 2022, 3:34 PM
tobiu referenced in commit dc1f135 - "#3477 component.Base: updateCls() => adjusted to work for cls & wrapperCls" on Sep 30, 2022, 3:43 PM
tobiu referenced in commit 5367f88 - "#3477 component.Base: updateCls() => adjusted the vnode find logic (matched via the (vdom) id)" on Sep 30, 2022, 3:54 PM
tobiu referenced in commit b9fb5f7 - "#3477 component.Base: afterSetCls() => cleanup" on Sep 30, 2022, 4:07 PM
tobiu
tobiu Sep 30, 2022, 4:41 PM

wrapperCls is in place now. Since probably 98% of your components won't need a wrapper, we need a smart way to merge it with cls to prevent overrides.

tobiu referenced in commit 63895ef - "#3477 component.Base: afterSetCls() => merging cls & wrapperCls" on Sep 30, 2022, 4:53 PM
tobiu referenced in commit c3381ea - "#3477 component.Base: cleanup" on Sep 30, 2022, 4:54 PM
tobiu referenced in commit 9abec3d - "#3477 layout.Fit: using wrapperCls" on Sep 30, 2022, 5:01 PM
tobiu referenced in commit 9e23c21 - "#3477 layout.Flexbox: using wrapperCls" on Sep 30, 2022, 5:06 PM
tobiu referenced in commit 6abc519 - "#3477 layout.HBox, layout.VBox: cleanup" on Sep 30, 2022, 5:08 PM
tobiu referenced in commit ee7d0c4 - "#3477 layout.Card: cleanup" on Sep 30, 2022, 5:13 PM
tobiu referenced in commit 8cdb248 - "#3477 component.Base: enhancements for afterSetCls(), afterSetWrapperCls() & vdom update calls" on Sep 30, 2022, 5:49 PM
tobiu
tobiu Sep 30, 2022, 10:14 PM

the conversion is done. i will create follow up tickets to look into side effects.

tobiu closed this issue on Sep 30, 2022, 10:14 PM